[HOLD for payment 2023-04-26] Update sign up/sign in screen imagery to match new branding

[shawnborton]

Note: This issue is part of the greater Implement Our New Branding in NewDot project.

What is it:
Updating the home page and sign up flow in the app to include our new illustrations. We’ll need to consider what this looks like for both mobile and desktop. Note that this may be adjusted based on passwordless flow.

Mini Design Doc can be found here: https://docs.google.com/document/d/1NxVst1XupNYpLVgknXPPlaQ2wAuR7-_8OmH442mQrzc/edit#

Does it require a mini design doc:
Yes, this requires code changes

Design finished:
No

cc @GabiHExpensify

[melvin-bot]

Auto-assign attempt failed, all eligible assignees are OOO.

[sketchydroide]

Happy to take this one, including helping with the design doc

[JmillsExpensify]

Nice, when do you expect to have a pre-design discussion kicked off? Let's start there.

[sketchydroide]

I think there are 2 main different things to change/update, the assets (images) and the style (colours, fonts, spacing, etc)

Images can be specific to each page, but styles might be common across the different screens.

Are we changing the style of the text @shawnborton? The Font feel different.

[sketchydroide]

I assume this has not been has important as WAQ so it will be kept in monthly?

[JmillsExpensify]

Good question. What are your thoughts there? I think there's an argument either way.

[shawnborton]

I think this still technically falls under WAQ Branding so we should treat it with urgency, and that's my bad for not having much progress to show yet.

[JmillsExpensify]

Cool, thought you'd say that. Sound good to me, and no worries!

[sketchydroide]

@shawnborton shall I start writing the mini doc for this?
I think I mostly need to understand what parts of the app will be changed, not exaclty the how the design is going to look, so if I can just go from the images you shared on the GH I think I have something to start working on.
Also we should probably move this to a least weekly so we can keep updating it.

Does this sound good? (I'm updating if you disagree we can move it back again :) )

[sketchydroide]

@shawnborton any input on the above :)

[shawnborton]

Hey Andre - sorry for the delay here. We had TCW explore this one last week and we'll provide some feedback to them today for where to take it next.

In terms of a mini design doc, that is totally your call - maybe let's wait to see the final proposed design changes and you can make the call from there? I do think there will be some considerations for mobile vs desktop, but otherwise I am hoping this is fairly straightforward.

[sketchydroide]

ok, will wait, where can I keep track of the changes, is there a slack thread for this?

[shawnborton]

Head over to the #expensify-tcw room, latest exploration is here.

[sketchydroide]

I think we are still waiting here

[shawnborton]

Okay, I think this is the version we're going with:

[sketchydroide]

will the new list of links be part of this rebranding, I would say at the moment that no, and we will leave that part empty on this project, as it's not exaclty rebranding, but a new feature.
If it is, it's going to be a slighlty larger project (not a lot though) but I've started to write the mini doc so just need to know if I should include those or not.

[sketchydroide]

@shawnborton are we loosing the way we can tell if the app is in Staging or Dev (and Prod)
This is now on the logo, but that seems to have been replaced the full Expensify one

[shawnborton]

We can probably add a small "stg" or "dev" icon near the wordmark, so no worries there.

For the footer links, we can certainly do them as a separate PR/issue if you would like to.

[sketchydroide]

We can probably add a small "stg" or "dev" icon near the wordmark, so no worries there.

sounds good, once we have a figma and assets going I can take care of that

For the footer links, we can certainly do them as a separate PR/issue if you would like to.

Can totally be part of this one, this one will be best to split into smaller GHs regardless, so adding a couple more to add the list of links is totally fine.

I mostly want to know if that already has a different GH or has anyone started working on it.

[shawnborton]

sounds good, once we have a figma and assets going I can take care of that

Cool, in the meantime though feel free to get started on this project and I'll follow up with the logo assets.

I mostly want to know if that already has a different GH or has anyone started working on it.

Got it, yeah I think that's a good question for @LLPeckham and @joaniew but I don't think individual GHs have been broken out just yet.

[sketchydroide]

This is a rough start for the document, but I've started it

[shawnborton]

Ah, I thought we were going to keep the footer changes separate for now and just plan to update the landing screen for the Sign In/Up page. If that's the case, do you think we need a design doc to implement the new sign in screen imagery?

[shawnborton]

Nice! I like that it is a little more consistent with desktop's copy.

[MelvinBot]

@shawnborton, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[grgia]

PR in final review stage

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.1-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• New Branding - New Sign In Imagery #15737

If no regressions arise, payment will be issued on 2023-04-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[grgia]

@maddylewis oh hey there :) could you help with payment for PR review? cc @thesahindia

[maddylewis]

ohhhh whaddya know!? and yes, let me get right on that <3

[maddylewis]

to clarify, i am processing a payment for $1000 to @thesahindia, correct?

[maddylewis]

offer sent! https://www.upwork.com/nx/wm/pre-hire/c/8577561/offer/24370485

[thesahindia]

to clarify, i am processing a payment for $1000 to @thesahindia, correct?

Yes. The compensation is $1000 for all the internal PR reviews.

[maddylewis]

paid!

[maddylewis]

do we need to keep this one open? or were we just waiting for the payment to process before closing this one out?

[shawnborton]

If everyone is paid, we can close it!