Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-09-23 #11252

Closed
14 tasks done
OSBotify opened this issue Sep 23, 2022 · 9 comments
Closed
14 tasks done

Deploy Checklist: New Expensify 2022-09-23 #11252

OSBotify opened this issue Sep 23, 2022 · 9 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 23, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.6-0 🚀

@mvtglobally
Copy link

@luacmartins @roryabraham

Regression is completed

PR #10491 is blocked #11281. We are stuck with this PR and need some additional eyes here
PR #11155 is failing #11264
PR #11219 is failing #11237 blocker was removed. are we ok to check off?

@roryabraham
Copy link
Contributor

I spent some time looking into it, and there were some problems with #10491, but those problems either have been reported or were not caused by that PR. None of them are deploy blockers, so I'm going to check it off

@roryabraham
Copy link
Contributor

#11264 has been closed as expected behavior. Checking off #11155

@roryabraham
Copy link
Contributor

Also checking off #11219

@roryabraham
Copy link
Contributor

I am seeing a substantial spike in homepage initial render timing on iOS and Android:

image

But I believe that can be attributed to #11206, which fixed a problem where TTI was captured noticeably before the app was actually interactable.

@roryabraham
Copy link
Contributor

This looks like a low-level issue, likely coming from Reanimated. Not going to block on it for now since it's only happened once.

@roryabraham
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants