-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log in - The Fab menu does not open automatically when log in with new account #10232
Comments
Triggered auto assignment to @robertjchen ( |
We are working on revamping this flow with the refactors, will revisit after those changes go out 🤔 |
Triggered auto assignment to @CortneyOfstad ( |
@kbecciv Hello! Just doing some GH clean-up and wanted to see if this issue was still occurring? If so, let me know and I can continue troubleshooting from a Triage perspective. Thanks! |
Triggered auto assignment to @tylerkaraszewski ( |
Sorry @tylerkaraszewski! Was in the wrong GH tab — PLEASE IGNORE! |
@CortneyOfstad Issue is still reproduced in build 1.2.17.4 Cursor.mp4 |
Triggered auto assignment to @Beamanator ( |
I can reproduce in staging! The weird thing is, when I searched through lots & data returned by cc @luacmartins I wonder if you have an idea what's going on here since you've worked a lot on |
Marking |
@Beamanator I did some quick debugging and the issue is that we no longer set the |
I'll assign myself them and keep track of the related PR. |
Aah nice thanks for the link @luacmartins 👍 |
@Beamanator the App PR was merged, but I noticed that Auth can return 0 or 1 instead of a bool, which makes the first part of this conditional fail. So I put up a fix here. |
I'm going to go ahead and do that @Beamanator and @luacmartins, and at that point we're just waiting for both PRs to hit production for this issue to close. Yeah? |
@JmillsExpensify that's correct! |
Awesome thank you! |
Both PRs are in prod. Closing this issue, please reopen if needed! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The Fab menu opens automatically when log in with new account
Actual Results:##
The Fab menu does not open automatically when log in with new account
Workaround:
Unknkown
Platform:
Where is this issue occurring?
Version Number: 1.1.87.8
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any new account
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Recording.880.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: