Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log in - The Fab menu does not open automatically when log in with new account #10232

Closed
kbecciv opened this issue Aug 3, 2022 · 19 comments
Closed
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Aug 3, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. In the email field, enter a gmail email address for a new account.
  3. Press continue
  4. Verify there’s a message saying that a Magic Link has been sent to the email address
  5. Navigate to the email inbox of the account and open the validation email
  6. Copy the link and change it to staging.
  7. Navigate to the staging link
  8. Verify you’re brought to the “Set a Password” page
  9. Set a password that follows the password requirements
  10. After setting the password, verify the user is navigated to the main screen and Fub menu is open automatically

Expected Result:

The Fab menu opens automatically when log in with new account

Actual Results:##

The Fab menu does not open automatically when log in with new account

Workaround:

Unknkown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.87.8

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any new account

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.880.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2022

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@robertjchen
Copy link
Contributor

We are working on revamping this flow with the refactors, will revisit after those changes go out 🤔

@melvin-bot melvin-bot bot removed the Overdue label Aug 6, 2022
@robertjchen robertjchen added Monthly KSv2 and removed Daily KSv2 labels Aug 6, 2022
@robertjchen robertjchen removed their assignment Sep 1, 2022
@JmillsExpensify JmillsExpensify added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 18, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member Monthly KSv2 Overdue labels Oct 18, 2022
@CortneyOfstad
Copy link
Contributor

@kbecciv Hello! Just doing some GH clean-up and wanted to see if this issue was still occurring? If so, let me know and I can continue troubleshooting from a Triage perspective. Thanks!

@CortneyOfstad CortneyOfstad added Improvement Item broken or needs improvement. and removed Engineering labels Oct 18, 2022
@CortneyOfstad CortneyOfstad removed their assignment Oct 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@CortneyOfstad
Copy link
Contributor

Sorry @tylerkaraszewski! Was in the wrong GH tab — PLEASE IGNORE!

@kbecciv
Copy link
Author

kbecciv commented Oct 18, 2022

@CortneyOfstad Issue is still reproduced in build 1.2.17.4

Cursor.mp4

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Beamanator
Copy link
Contributor

I can reproduce in staging! The weird thing is, when I searched through lots & data returned by OpenApp I saw "isFirstTimeExpensifyUser": "true" - I wonder if the problem is that there's just soooo much data coming back in that command?

cc @luacmartins I wonder if you have an idea what's going on here since you've worked a lot on OpenApp I think?

@Beamanator Beamanator removed their assignment Oct 19, 2022
@Beamanator Beamanator added the Internal Requires API changes or must be handled by Expensify staff label Oct 19, 2022
@Beamanator
Copy link
Contributor

Marking Internal b/c this could definitely be related to our API side code

@luacmartins
Copy link
Contributor

@Beamanator I did some quick debugging and the issue is that we no longer set the IS_LOADING_POLICY_DATA key in OpenApp, so this promise never resolves and we don't show the FAB menu. We have a PR that should fix this

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@JmillsExpensify
Copy link

I'll assign myself them and keep track of the related PR.

@JmillsExpensify JmillsExpensify changed the title Log in - The Fab menu does not open automatically when log in with new account [HOLD #11627] Log in - The Fab menu does not open automatically when log in with new account Oct 19, 2022
@JmillsExpensify JmillsExpensify self-assigned this Oct 19, 2022
@Beamanator Beamanator self-assigned this Oct 20, 2022
@Beamanator
Copy link
Contributor

Aah nice thanks for the link @luacmartins 👍

@luacmartins luacmartins self-assigned this Oct 20, 2022
@luacmartins
Copy link
Contributor

@Beamanator the App PR was merged, but I noticed that Auth can return 0 or 1 instead of a bool, which makes the first part of this conditional fail. So I put up a fix here.

@luacmartins luacmartins added the Reviewing Has a PR in review label Oct 20, 2022
@JmillsExpensify
Copy link

Given that both the linked PR that put this issue on hold is now on staging, and related, so is the PR fix mentioned immediately above, let's take this issue off hold, right?

@JmillsExpensify
Copy link

I'm going to go ahead and do that @Beamanator and @luacmartins, and at that point we're just waiting for both PRs to hit production for this issue to close. Yeah?

@JmillsExpensify JmillsExpensify changed the title [HOLD #11627] Log in - The Fab menu does not open automatically when log in with new account Log in - The Fab menu does not open automatically when log in with new account Oct 26, 2022
@luacmartins
Copy link
Contributor

@JmillsExpensify that's correct!

@JmillsExpensify
Copy link

Awesome thank you!

@luacmartins
Copy link
Contributor

Both PRs are in prod. Closing this issue, please reopen if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

8 participants