Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of window in the cross platform ReportScreen component #10204

Closed
neil-marcellini opened this issue Aug 2, 2022 · 0 comments
Closed
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@neil-marcellini
Copy link
Contributor

Problem

Coming from this comment #9031 (comment)

We really shouldn't be seeing window unless we are in an index.js file and there's an index.native.js that is doing a no-op.

Solution

create a small lib that returns something like VisualViewport we can call addEventListener() on and for mobile it would just return an empty function.

See #9031 (comment)

@neil-marcellini neil-marcellini added Engineering Weekly KSv2 Improvement Item broken or needs improvement. labels Aug 2, 2022
@neil-marcellini neil-marcellini self-assigned this Aug 2, 2022
@neil-marcellini neil-marcellini added the Reviewing Has a PR in review label Aug 2, 2022
@marcaaron marcaaron added the Internal Requires API changes or must be handled by Expensify staff label Aug 2, 2022
@melvin-bot melvin-bot bot closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants