Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS - Search - List of users is hidden after tap on Search icon #10105

Closed
kbecciv opened this issue Jul 26, 2022 · 5 comments
Closed

IOS - Search - List of users is hidden after tap on Search icon #10105

kbecciv opened this issue Jul 26, 2022 · 5 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jul 26, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with expensifail account
  3. Tap on Search icon

Expected Result:

List of users is hidden after tap on Search icon

Actual Result:

Users are visible after tap on Search icon

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.1.86.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Image.from.iOS.42.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jul 26, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@luacmartins
Copy link
Contributor

I could reproduce this and it seems related to the KeyboardAvoidingView changes @jasperhuangg

@luacmartins
Copy link
Contributor

Removing the KeyboardSpacer component from here fixes the issue, but I suspect this was caused by changes in ScreenWrapper.

@luacmartins luacmartins self-assigned this Jul 26, 2022
@jasperhuangg
Copy link
Contributor

@luacmartins Ah, I bet the problem is caused by the KeyboardSpacer being wrapped inside of a KeyboardAvoidingView.

@luacmartins
Copy link
Contributor

This seems to be fixed with this revert - #10113. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants