Payment - "You appears to be offline" is duplicated

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing #9895

Action Performed:

1. Sign into an account on NewDot.
2. Turn on your wifi.
3. Go to settings > Payment

Expected Result:

"You appears to be offline" - must be displayed once

Actual Result:

"You appears to be offline" message is duplicated

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS
• Android
• Mobile Web

Version Number: 1.1.86-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5662761_ios_9896-video.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[NikkiWines]

Oops sorry, missed my assignment to this - was catching up from being OOO. Looking into it now

[jasperhuangg]

@NikkiWines I have a feeling it could be related to #9895, which I'm about to revert. Will let you know if this fixes the problem!

[NikkiWines]

Ah, yeah, I think you're right. The OfflineIndicator is shown on small screens on the ScreenWrapper (added in #9895) but the OfflineIndicator was also added to the BasePaymentsPage in #9589 so it'll end up showing twice on that page.

[NikkiWines]

Looks like a revert PR for #9895 has been merged and deployed to staging. Testing now to see if I can reproduce the original error

[NikkiWines]

Hmm, ok. Now looks like there's no offline indicator whatsoever since it's been removed from both ScreenWrapper and BasePaymentsPage.

@jasperhuangg @MariaHCD since you both worked on the offline indicator for these pages and there's been some crossed wires, what do you want to do going forward? I think we should add back in OfflineIndicator to BasePaymentsPage while we're waiting for the v2 of #9895. Thoughts?

[NikkiWines]

Either way I don't think this is a blocker anymore since there's no duplication of the offline indicator anymore. Going to adjust the labels appropriately and keep it assigned.

[luacmartins]

So right now we have no You appear to be offline message? It seems ok to remove the blocker status, but we should fix this soon.

[MariaHCD]

I think we should add back in OfflineIndicator to BasePaymentsPage while we're waiting for the v2 of #9895. Thoughts?

This sounds good to me!