Web - Profile settings - Timezone drop down opens after using Enter Key twice

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to Settings/Profile settings
4. Use the "Tab" key to go to the timezone selection (the time zone should not be selected for automatic selection)
5. Press Enter key

Expected Result:

Timezone drop down opens after using Enter Key once

Actual Result:

Timezone drop down opens after using Enter Key twice

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.85.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5655575_Recording__1203.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

After looking at the code I think this is happening because this button has pressOnEnter passed to it. This is what's happening in the video:

1. You're able to first open the pronouns dropdown with Enter because the button is disabled (since no changes to the form have been made yet).
2. After you change your pronouns, the button detects a change in the form, becomes enabled and starts listening for Enter presses.
3. When you go to open the timezone dropdown with Enter, the now-enabled button picks up this Enter press and stops it from propagating to the dropdown.
4. Then, the button becomes disabled again, and the next time you hit Enter it's picked up by the timezone dropdown and opens it.

This isn't necessarily a bug, since it's expected that the button behaves this way, and it doesn't necessarily make the form unusable in regards to accessibility. The user just has to change and save each field one-at-a-time if they're navigating with the keyboard. Therefore I'm electing to close this out.