Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room - Details - Time zone is not displayed in member list of room. #10018

Closed
kbecciv opened this issue Jul 20, 2022 · 5 comments
Closed

Room - Details - Time zone is not displayed in member list of room. #10018

kbecciv opened this issue Jul 20, 2022 · 5 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jul 20, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #9642

Action Performed:

  1. Launch the app
  2. Click on fab icon > new workspace (if you don't have any workspace)
  3. Search #announce room and open it (note: the room should only contain one other member except you)
  4. Check the time zone of the user

Expected Result:

The time zone of that other user should be displayed.

Actual Result:

The time zone of that other user is not displayed.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.85.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5654737_mem.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2022

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@youssef-lr
Copy link
Contributor

cc @Puneet-here
What is the expected behavior for showing the timezone in rooms where there’s just one or two members? Screenshot below are from production, is it working as expected?
Screen Shot 2022-07-20 at 20 31 41
Screen Shot 2022-07-20 at 20 31 32

@Puneet-here
Copy link
Contributor

Puneet-here commented Jul 20, 2022

Hi @youssef-lr, if you are the only person in the room then the timezone shouldn't be shown. If there is one more member other than you then we should see the timezone of that other user.

Note: The PR hasn't reached production or staging yet.

@youssef-lr
Copy link
Contributor

Thanks @Puneet-here. Should we close this issue?

@Puneet-here
Copy link
Contributor

@youssef-lr, yeah we should close it. We can reopen if we see some issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants