Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Chat - When hit (CTRL+K) after opening global action button, Global action button and search modal opens #10009

Closed
kavimuru opened this issue Jul 19, 2022 · 4 comments
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2 Not a priority

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Click on the "Global action" button
  3. Press on CTRL + K

Expected Result:

The first modal should be closed when the second is opened

Actual Result:

Both Global action button and search modal opens

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: v1.1.85-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5654645_Screenshot_2022-07-19_213258

Bug5654645_Recording__1200.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2022

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Gonals Gonals added Monthly KSv2 Improvement Item broken or needs improvement. and removed Daily KSv2 labels Jul 21, 2022
@Gonals
Copy link
Contributor

Gonals commented Jul 21, 2022

Not a huge deal. Setting as monthly!

@Gonals Gonals removed their assignment Jul 21, 2022
@kbecciv
Copy link

kbecciv commented Aug 5, 2022

@Gonals One of the tester experienced a similar issue. When open the New room through the FAB menu and press the spacebar on the keyboard, then the FAB menu will additionally open again.

Recording.1377.mp4

@melvin-bot melvin-bot bot closed this as completed Oct 3, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2022

@kavimuru, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2 Not a priority
Projects
None yet
Development

No branches or pull requests

3 participants