Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ALT overriding text input #59

Closed
wants to merge 1 commit into from
Closed

Conversation

tonsa1
Copy link
Contributor

@tonsa1 tonsa1 commented Jan 17, 2024

Issue: #16

Set is_editing to true when an active panel begins an edit. If the panel focus goes somewhere else and the edit is still live in the background it should let you use ALT normally. This doesn't take commands into account so they need to be checked seperately.

One other check that I noticed was ws->autocomp_last_frame_idx+1 >= df_frame_index() but this would only work for name types, like expressions where you have the auto complete available. The check in the commit should work for all input types that are build in DF_VIEW_UI_FUNCTION_DEF.

@tonsa1
Copy link
Contributor Author

tonsa1 commented Jan 20, 2024

If this approach not something you prefer I can edit it if you could share some quick feedback on this @ryanfleury. I can also close this if you would prefer to do it yourself.

@ryanfleury
Copy link
Collaborator

This issue was being caused by the debugger not properly interpreting AltGr-based input events correctly, and being too permissive in menu bar hotkey shortcuts, so the correct fix was a bit different.

@ryanfleury ryanfleury closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants