Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splunk Custom Steps #411

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Splunk Custom Steps #411

merged 1 commit into from
Jul 29, 2020

Conversation

stjarna
Copy link

@stjarna stjarna commented Jul 20, 2020

The changes relate to Splunk custom steps. The intention is to let dev teams to assert some of the events also in Splunk logs.

Please note that the test runs against mocked Splunk instance and the development was conducted with locally running Splunk Docker image.

There have been some talks with EIT Splunk Monitoring team to let us to use java sdk, but it may take a while until we are capable to use it in EIT domain.

@paveljandejsek
Copy link
Contributor

Solves #398

Copy link
Contributor

@paveljandejsek paveljandejsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have just some minor comments, most are just my personal opinions so probably wait for other review before doing any changes 🙂

Btw. the person merging this should create a new issue to create splunk reporting extension based on the final implementation of this MR

pom.xml Show resolved Hide resolved
@stjarna
Copy link
Author

stjarna commented Jul 22, 2020

FYI, I was also discussing with Pavel possibility to use @ConditionalOnProperty or @ConditionalOnExpression that would check on the presence of particular Splunk property in env in case of SplunkClient instantiation.

Both annotations are from spring.boot.autoconfigure and we decided that we will skip it as well as we wont also implement own conditional.

@thradec thradec merged commit b82e3c8 into EmbedITCZ:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants