-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splunk Custom Steps #411
Splunk Custom Steps #411
Conversation
Solves #398 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have just some minor comments, most are just my personal opinions so probably wait for other review before doing any changes 🙂
Btw. the person merging this should create a new issue to create splunk reporting extension based on the final implementation of this MR
jbehave-support-core/src/main/java/org/jbehavesupport/core/splunk/SplunkClient.java
Outdated
Show resolved
Hide resolved
jbehave-support-core/src/main/java/org/jbehavesupport/core/splunk/SplunkClient.java
Outdated
Show resolved
Hide resolved
jbehave-support-core/src/main/java/org/jbehavesupport/core/splunk/SplunkConfig.java
Show resolved
Hide resolved
jbehave-support-core/src/main/java/org/jbehavesupport/core/splunk/SplunkSteps.java
Outdated
Show resolved
Hide resolved
FYI, I was also discussing with Pavel possibility to use @ConditionalOnProperty or @ConditionalOnExpression that would check on the presence of particular Splunk property in env in case of SplunkClient instantiation. Both annotations are from spring.boot.autoconfigure and we decided that we will skip it as well as we wont also implement own conditional. |
The changes relate to Splunk custom steps. The intention is to let dev teams to assert some of the events also in Splunk logs.
Please note that the test runs against mocked Splunk instance and the development was conducted with locally running Splunk Docker image.
There have been some talks with EIT Splunk Monitoring team to let us to use java sdk, but it may take a while until we are capable to use it in EIT domain.