-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the possibility to send an empty json list in rest steps #334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice first PR, good work!
Couple of thoughts from my side:
- I know that it was like that in the previous versions and is the same with the other pattern - but are we able to replace this with something like
indexedKeyPattern3.pattern() + ".*"
to avoid repetition of the same pattern again? Not saying to do it, just wondering if its possible or if there is some problem I am not seeing at first glance. Also if possible I would probably rename theindexedKeyPattern*
variables to something more readable (again not saying to do it in this PR, but might be worth creating issue/another PR for it) - This solution supports only the
[]
notation for the array in examples table not the.
one, are we okay with that? (I dont have a clue how we would even write it for the dot case, just want to point it out that this is the case). - Can you add some example to the markdown documentation as well?
…xed 3 SonarLint warnings
aa26ae3
to
a127e1e
Compare
Thanks for the feedback :) In order:
|
Dont do them just yet, I am just wondering if its possible for some future work, or if what I said is total BS 🙂
I dont know myself either, I cant think of any "nice" way to write it with dot notation, but I am personally fine without it - so I would maybe leave this point open till wednesday when hopefully more people will take a look at it.
Awesome, approved by me 👍 |
Added the possibility to send an empty json list in rest steps and fixed 3 SonarLint warnings.
Solves #326