-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added asserts to web steps mandatory columns #208
Conversation
Generated reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question - would the asserts be more readable with assertThat from assertj? (supports String formatting with %s)
Don't Repeat Yourself => Utility method for soft asserting. |
51e7580
to
4ec568e
Compare
What about this solution? |
Generated reports |
1 similar comment
Generated reports |
jbehave-support-core/src/main/java/org/jbehavesupport/core/web/WebSteps.java
Outdated
Show resolved
Hide resolved
Maybe ExamplesTableUtil? Or ExampleTableConstraints? Dont know but I agree that it feels useful enough to be moved somewhere 🙂 |
4ec568e
to
3306f26
Compare
Method moved to ExamplesTableUtil. |
Generated reports |
jbehave-support-core/src/main/java/org/jbehavesupport/core/internal/ExamplesTableUtil.java
Outdated
Show resolved
Hide resolved
3306f26
to
11e6a32
Compare
Generated reports |
jbehave-support-core/src/main/java/org/jbehavesupport/core/internal/ExamplesTableUtil.java
Outdated
Show resolved
Hide resolved
…ernal/ExamplesTableUtil.java Co-Authored-By: Pavel Jandejsek <43804753+paveljandejsek@users.noreply.github.com>
Generated reports |
Can we have this functionality covered by tests? |
Generated reports |
jbehave-support-core/src/main/java/org/jbehavesupport/core/internal/ExamplesTableUtil.java
Outdated
Show resolved
Hide resolved
…support into WebStepsAsserts # Conflicts: # jbehave-support-core/src/main/java/org/jbehavesupport/core/internal/ExamplesTableUtil.java
66f6ad0
to
dfe982e
Compare
Generated reports |
Fixed issue #192