Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added asserts to web steps mandatory columns #208

Merged
merged 4 commits into from
Nov 19, 2019
Merged

Added asserts to web steps mandatory columns #208

merged 4 commits into from
Nov 19, 2019

Conversation

xsmrcek
Copy link
Contributor

@xsmrcek xsmrcek commented Oct 24, 2019

Fixed issue #192

@paveljandejsek
Copy link
Contributor

Generated reports

paveljandejsek
paveljandejsek approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@paveljandejsek paveljandejsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question - would the asserts be more readable with assertThat from assertj? (supports String formatting with %s)

@AmyKosinova
Copy link
Contributor

Don't Repeat Yourself => Utility method for soft asserting.

@xsmrcek xsmrcek force-pushed the WebStepsAsserts branch 2 times, most recently from 51e7580 to 4ec568e Compare November 2, 2019 18:01
@xsmrcek
Copy link
Contributor Author

xsmrcek commented Nov 2, 2019

Don't Repeat Yourself => Utility method for soft asserting.

What about this solution?
If you are happy with it:
What about moving it somewhere else (idk where) so we can reuse it in more steps?

@paveljandejsek
Copy link
Contributor

Generated reports

1 similar comment
@paveljandejsek
Copy link
Contributor

Generated reports

@paveljandejsek
Copy link
Contributor

paveljandejsek commented Nov 2, 2019 •
edited
Loading

What about moving it somewhere else (idk where) so we can reuse it in more steps?

Maybe ExamplesTableUtil? Or ExampleTableConstraints? Dont know but I agree that it feels useful enough to be moved somewhere 🙂

@xsmrcek
Copy link
Contributor Author

xsmrcek commented Nov 4, 2019

Method moved to ExamplesTableUtil.

@paveljandejsek
Copy link
Contributor

Generated reports

@paveljandejsek
Copy link
Contributor

Generated reports

@xsmrcek @paveljandejsek
Update jbehave-support-core/src/main/java/org/jbehavesupport/core/int…
b939f49 
…ernal/ExamplesTableUtil.java

Co-Authored-By: Pavel Jandejsek <43804753+paveljandejsek@users.noreply.github.com>
@paveljandejsek
Copy link
Contributor

Generated reports

@AmyKosinova
Copy link
Contributor

Can we have this functionality covered by tests?

@paveljandejsek
Copy link
Contributor

Generated reports

@xsmrcek
Merge branch 'WebStepsAsserts' of https://github.com/xsmrcek/jbehave-…
dfe982e 
…support into WebStepsAsserts

# Conflicts:
#	jbehave-support-core/src/main/java/org/jbehavesupport/core/internal/ExamplesTableUtil.java
@paveljandejsek
Copy link
Contributor

Generated reports

@AmyKosinova AmyKosinova merged commit 5813792 into EmbedITCZ:master Nov 19, 2019
@xsmrcek xsmrcek deleted the WebStepsAsserts branch January 20, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paveljandejsek paveljandejsek paveljandejsek approved these changes

@AmyKosinova AmyKosinova AmyKosinova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xsmrcek @paveljandejsek @AmyKosinova