Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split report.xslt to multiple files #148

Merged
merged 5 commits into from
Aug 8, 2019
Merged

Split report.xslt to multiple files #148

merged 5 commits into from
Aug 8, 2019

Conversation

Hebcak
Copy link
Contributor

@Hebcak Hebcak commented Jul 22, 2019

Closes #137

@paveljandejsek
Copy link
Contributor

It seems like copying in XmlReporterFactory is not working correctly. Try to take a look locally at XmlReportIT, it might help to figure out whats wrong...

@paveljandejsek
Copy link
Contributor

Generated reports

1 similar comment
@paveljandejsek
Copy link
Contributor

Generated reports

paveljandejsek
paveljandejsek requested changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@paveljandejsek paveljandejsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just some comments about the jar handling, I think we should make it a bit more readable if possible...

Btw. do we really need the:
<xsl:template match="/"></xsl:template>
blocks in the partial templates or will it work without them?

jbehave-support-core/src/main/java/org/jbehavesupport/core/report/XmlReporterFactory.java Show resolved Hide resolved
jbehave-support-core/src/main/java/org/jbehavesupport/core/report/XmlReporterFactory.java Outdated Show resolved Hide resolved
jbehave-support-core/src/main/java/org/jbehavesupport/core/report/XmlReporterFactory.java Show resolved Hide resolved
jbehave-support-core/src/main/java/org/jbehavesupport/core/report/XmlReporterFactory.java Outdated Show resolved Hide resolved
jbehave-support-core/src/main/java/org/jbehavesupport/core/report/XmlReporterFactory.java Outdated Show resolved Hide resolved
@paveljandejsek
Copy link
Contributor

Generated reports

1 similar comment
@paveljandejsek
Copy link
Contributor

Generated reports

paveljandejsek
paveljandejsek requested changes Jul 30, 2019
View reviewed changes
jbehave-support-core/src/main/java/org/jbehavesupport/core/jms/InterceptedMessageCreator.java Outdated Show resolved Hide resolved
jbehave-support-core/src/main/java/org/jbehavesupport/core/jms/InterceptedMessageCreator.java Outdated Show resolved Hide resolved
...ort-core/src/main/java/org/jbehavesupport/core/report/extension/JmsXmlReporterExtension.java Outdated Show resolved Hide resolved
jbehave-support-core/src/main/resources/functions.js Outdated Show resolved Hide resolved
jbehave-support-core/src/main/resources/index.xslt Outdated Show resolved Hide resolved
jbehave-support-core/src/main/resources/report-generator/screenshotReport.xslt Outdated Show resolved Hide resolved
jbehave-support-core/src/main/resources/report-generator/serverLogXmlRep.xslt Outdated Show resolved Hide resolved
@Hebcak Hebcak changed the title Split report.xslt to multiple files Split report.xslt to multiple files & added JMS reporter Jul 31, 2019
@paveljandejsek
Copy link
Contributor

Generated reports

@Hebcak Hebcak changed the title Split report.xslt to multiple files & added JMS reporter Split report.xslt to multiple files Jul 31, 2019
@paveljandejsek paveljandejsek mentioned this pull request Jul 31, 2019
Merged
@paveljandejsek
Copy link
Contributor

Please rebase, ci and the reporting service were updated to support folders in reports....

@paveljandejsek
Copy link
Contributor

Generated reports

@paveljandejsek
Copy link
Contributor

Generated reports

2 similar comments
@paveljandejsek
Copy link
Contributor

Generated reports

@paveljandejsek
Copy link
Contributor

Generated reports

@paveljandejsek
Copy link
Contributor

Generated reports

1 similar comment
@paveljandejsek
Copy link
Contributor

Generated reports

@paveljandejsek
Copy link
Contributor

Generated reports

@paveljandejsek paveljandejsek mentioned this pull request Aug 5, 2019
Merged
@Hebcak
Addressed comment: "In this case stream brings more problems than imp…
da08494 
…roves readability. I suggest to refactor it to iterator approach"
@paveljandejsek
Copy link
Contributor

Generated reports

@AmyKosinova AmyKosinova merged commit 2e879c2 into EmbedITCZ:master Aug 8, 2019
@Hebcak Hebcak deleted the XSLT branch August 8, 2019 13:21
xsmrcek pushed a commit to xsmrcek/jbehave-support that referenced this pull request Aug 17, 2019
@Hebcak
Split report.xslt to multiple files (EmbedITCZ#148)
9e8e795 
Split report style sheet to multiple files
@Hebcak Hebcak mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmyKosinova AmyKosinova AmyKosinova approved these changes

@paveljandejsek paveljandejsek paveljandejsek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split xslt template(s) into multiple files
3 participants
@Hebcak @paveljandejsek @AmyKosinova