-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split report.xslt to multiple files #148
Conversation
It seems like copying in XmlReporterFactory is not working correctly. Try to take a look locally at XmlReportIT, it might help to figure out whats wrong... |
Generated reports |
1 similar comment
Generated reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just some comments about the jar handling, I think we should make it a bit more readable if possible...
Btw. do we really need the:
<xsl:template match="/"></xsl:template>
blocks in the partial templates or will it work without them?
jbehave-support-core/src/main/java/org/jbehavesupport/core/report/XmlReporterFactory.java
Show resolved
Hide resolved
jbehave-support-core/src/main/java/org/jbehavesupport/core/report/XmlReporterFactory.java
Outdated
Show resolved
Hide resolved
jbehave-support-core/src/main/java/org/jbehavesupport/core/report/XmlReporterFactory.java
Show resolved
Hide resolved
jbehave-support-core/src/main/java/org/jbehavesupport/core/report/XmlReporterFactory.java
Outdated
Show resolved
Hide resolved
jbehave-support-core/src/main/java/org/jbehavesupport/core/report/XmlReporterFactory.java
Outdated
Show resolved
Hide resolved
Generated reports |
1 similar comment
Generated reports |
jbehave-support-core/src/main/java/org/jbehavesupport/core/jms/InterceptedMessageCreator.java
Outdated
Show resolved
Hide resolved
jbehave-support-core/src/main/java/org/jbehavesupport/core/jms/InterceptedMessageCreator.java
Outdated
Show resolved
Hide resolved
...ort-core/src/main/java/org/jbehavesupport/core/report/extension/JmsXmlReporterExtension.java
Outdated
Show resolved
Hide resolved
jbehave-support-core/src/main/resources/report-generator/screenshotReport.xslt
Outdated
Show resolved
Hide resolved
jbehave-support-core/src/main/resources/report-generator/serverLogXmlRep.xslt
Outdated
Show resolved
Hide resolved
Generated reports |
Please rebase, ci and the reporting service were updated to support folders in reports.... |
Generated reports |
jbehave-support-core/src/main/java/org/jbehavesupport/core/report/XmlReporterFactory.java
Show resolved
Hide resolved
Generated reports |
Generated reports |
1 similar comment
Generated reports |
jbehave-support-core/src/main/java/org/jbehavesupport/core/report/XmlReporterFactory.java
Outdated
Show resolved
Hide resolved
jbehave-support-core/src/main/java/org/jbehavesupport/core/report/XmlReporterFactory.java
Show resolved
Hide resolved
… same, can be reduced to one."
Generated reports |
…roves readability. I suggest to refactor it to iterator approach"
Generated reports |
Split report style sheet to multiple files
Closes #137