Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched to constructor injection #136

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Switched to constructor injection #136

merged 1 commit into from
Jul 16, 2019

Conversation

paveljandejsek
Copy link
Contributor

@paveljandejsek paveljandejsek commented Jul 3, 2019 •
edited
Loading

I left @Autowired on:

  • optional dependencies
  • groovy files
  • abstract classes / classes where inheritance is expected - so requiredargs ctor can be used there without any hassle

@paveljandejsek paveljandejsek changed the title Switched to constructor injection + removed semicolons in groovy files WIP - Switched to constructor injection + removed semicolons in groovy files Jul 3, 2019
@paveljandejsek paveljandejsek force-pushed the ctorInjection branch 2 times, most recently from 97f90db to 899df1e Compare July 12, 2019 14:03
@paveljandejsek
Copy link
Contributor Author

Generated reports

@paveljandejsek paveljandejsek changed the title WIP - Switched to constructor injection + removed semicolons in groovy files Switched to constructor injection Jul 12, 2019
@mbocek mbocek merged commit 4a27419 into EmbedITCZ:master Jul 16, 2019
@paveljandejsek paveljandejsek deleted the ctorInjection branch December 13, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbocek mbocek mbocek approved these changes

@AmyKosinova AmyKosinova AmyKosinova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paveljandejsek @mbocek @AmyKosinova