Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include dependencies used for specified targets #36

Closed
repi opened this issue Dec 24, 2019 · 1 comment
Closed

Only include dependencies used for specified targets #36

repi opened this issue Dec 24, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@repi
Copy link
Contributor

repi commented Dec 24, 2019

We need to fix so we only include and attribute crates that we actually use for the target platforms we ship on. Right now all dependencies are included even if they are for fairly exotic targets that we do not use nor ship (redox, fuchsia).

Would be good to keep the current behavior and include dependencies from all targets, but add being able to specify which targets to include and filter for, including supporting multiple targets.
Could have such a config in about.toml of supported targets, as Cargo doesn't have it itself anywhere yet (though really should have). But would also be useful to be able to specify target to generate for with a --target parameter so one can quickly test a specific target or in CI generate target-specific correct output.

In Rust 1.41 the lockfile should contain the target information also so should then add this support together with the target-filtering in cargo-deny (EmbarkStudios/cargo-deny#63).

@repi repi added the enhancement New feature or request label Dec 24, 2019
@Jake-Shadle
Copy link
Member

Oops, this was fixed in #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants