Multiline lambda parameters

[ctbarbour]

According to the Code Convention documentation:

When declaring parameter names in a multiline lambda, put the names on the first line, followed by the arrow and the newline:

So the example should probably read:

class Test {
    fun tryAdd(a: Int?, b: Int?): Int? {
        var result: Int? = null
        a?.let { lhs ->
            b?.let { rhs ->
                result = lhs + rhs
            }
        }
        return result
    }
}

However, when putting parameters on the first line Kotlin-mode will indent the next line as follows:

class Test {                                                                                                                                                                             
    fun tryAdd(a: Int?, b: Int?): Int? {                                                                                                                                                 
        var result: Int? = null                                                                                                                                                          
        a?.let { lhs ->                                                                                                                                                                  
                     b?.let { rhs ->                                                                                                                                                     
                                  result = lhs + rhs                                                                                                                                     
                     }                                                                                                                                                                   
        }                                                                                                                                                                                
        return result                                                                                                                                                                    
    }                                                                                                                                                                                    
}

Further when adding normal declarations like variable assignment the first line is indented further than the remaining lines in the lambda:

class Test {                                                                                                                                                                             
    fun tryAdd(a: Int?, b: Int?): Int? {                                                                                                                                                 
        var result: Int? = null                                                                                                                                                          
        a?.let { lhs ->                                                                                                                                                                  
                     val test = "variable assignment"                                                                                                                                    
                 val anotherVariable = "another"                                                                                                                                         
                 b?.let { rhs ->                                                                                                                                                         
                              result = lhs + rhs                                                                                                                                         
                 }                                                                                                                                                                       
        }                                                                                                                                                                                
        return result                                                                                                                                                                    
    }                                                                                                                                                                                    
}

[taku0]

#53 will fix this.

class Test {
    fun tryAdd(a: Int?, b: Int?): Int? {
        var result: Int? = null
        a?.let { lhs ->
            b?.let { rhs ->
                result = lhs + rhs
            }
        }
        return result
    }
}

class Test {
    fun tryAdd(a: Int?, b: Int?): Int? {
        var result: Int? = null
        a?.let { lhs ->
            val test = "variable assignment"
            val anotherVariable = "another"
            b?.let { rhs ->
                result = lhs + rhs
            }
        }
        return result
    }
}

foo {
    context: Context,
    environment: Env
    ->
    context.configureEnv(environment)
}

foo { context: Context, // Non-standard style
      environment: Env
      ->
    context.configureEnv(environment)
}

[ctbarbour]

I'll give that a try. Thanks!

[rudolf-adamkovic]

This still does not work, does it?

assets.open(name).use { source ->
                            // indents here
}

Please reopen. #53 seems to have stalled.

[bricka]

I was also annoyed by this and have an MR up to fix it: #73

[taku0]

Now fixed as #53 is merged.