Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core-Enhances] Refactor TaskExecutorManager$1.class to a descriptive name #10

Open
pavly-gerges opened this issue Aug 17, 2023 · 1 comment
Open

[Core-Enhances] Refactor TaskExecutorManager$1.class to a descriptive name #10

pavly-gerges opened this issue Aug 17, 2023 · 1 comment
Labels
core Jector core related stuff design-correction Specifies an architecture correction PR enhancement New feature or request good first issue Good for newcomers

Comments

@pavly-gerges
Copy link
Member

pavly-gerges commented Aug 17, 2023 •
edited
Loading

It will be better to refactor this anonymous class to a private class with a proper name describing what it really does, in this case, it executes a method stack, so a MethodStack or StackExecutor or StackHandler may be better, it will be likely a StackHandler.
@pavly-gerges pavly-gerges added enhancement New feature or request good first issue Good for newcomers core Jector core related stuff design-correction Specifies an architecture correction PR labels Aug 17, 2023
@pavly-gerges
Copy link
Member Author

A StackFrameHandler may be a better alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Jector core related stuff design-correction Specifies an architecture correction PR enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pavly-gerges