Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible hang in Proxy code for Android #51

Open
Eilon opened this issue Mar 11, 2024 · 1 comment
Open

Fix possible hang in Proxy code for Android #51

Eilon opened this issue Mar 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Eilon
Copy link
Owner

Eilon commented Mar 11, 2024

In #43 a new proxy feature was introduced. Some of the code does sync-over-async, and calls .Wait() to block the async call. Unfortunately on iOS/MacCat this seems to hang 100% of the time. On Android there is similar code but doesn't seem to hang (but presumably it could).

We need to investigate a pattern to avoid the calls to .Wait() by finding a proper way to do async on iOS/MacCat/Android for these calls.

Example problematic call: https://github.com/Eilon/MauiHybridWebView/pull/43/files#diff-7580ae2f86a455f984e4ba3b09acf21b36bd79c70efa55d467f2df93a6c6f136R54

@Eilon Eilon added the bug Something isn't working label Mar 11, 2024
@Eilon
Copy link
Owner Author

Eilon commented Mar 11, 2024

The PR has fixes for iOS and MacCat now! But Android still calls .Wait(). Though no hang is currently known, it's something we need to address eventually.

@Eilon Eilon changed the title Fix hang in Proxy code for iOS/MacCat (and possibly Android) Fix possible hang in Proxy code for Android Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant