-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lua): deliver EVT_TOUCH_RELEASE event #5587
Conversation
Looks like the LUA constant EVT_TOUCH_RELEASE isn't generated (from keys.h???). |
radio/src/lua/api_general.cpp - section starting at line 3194 |
LUA constant EVT_TOUCH_RELEASE added |
@pfeerick I think this requires also some minor changes in |
Possibly. That will be a seperate PR though - source is here
@philmoz Happy with the state of this PR? |
Ok, I'll make a PR to implement a |
EVENT_TOUCH_RELEASE and _MSK_KEY_RELEASE are not needed. The existing EVENT_TOUCH_BREAK and _MSK_KEY_BREAK values should be covering the touch release state; but the code is not working. I suggest removing EVENT_TOUCH_RELEASE and using EVENT_TOUCH_BREAK in the event_cb() function and also delete these non-functional lines from the LuaEventHandler::onClicked() function. } else {
es->event = EVT_TOUCH_BREAK; |
Thanks, I'll have a look at that. |
(needs PR EdgeTX/edgetx#5587 )
LGTM on TX16S - EventDemo and LibGUI Demos both appear to be be fully functional still. Thanks for the complimentary LibGUI PR, that looks good also. |
first try to solve #5585
Resolves #5585