fix(radio): various issues with rotary encoder. #5194
Conversation
There was a problem hiding this comment.
I've tested TX12, TX12MK2, T20, Zorro, T16, X9D+2019, TX16S-Mk1 and TX16S-Mk2 with this PR, with no issues in radio firmware or bootloader.
I also tested the 2.10 test build of this on TX16S-Mk1, TX16S-Mk2 and T16. philmoz tested on X7S, TX16S Mk2, T20V2, T14, T15 and MT12. Joseph has tested T16 and Mickey has tested TX16S Mk1. So it's been pretty well covered 🤣
I'll leave this until tomorrow to allow for others to review ;)
|
There are some complications arising when the radio is started with the encoder not positioned on a detent. While this is not a normal state it could happen, and I'm trying to work out a solution. (Current 2.10 code also misbehaves if radio is started with encoder not on a detent) |
Fix potential issue with ENTER key.
philmoz
force-pushed
the
philmoz/rotenc-update
branch
from
7f9ecd2
to
8c591cc
Compare
|
Updated to handle the case when the radio is started with the encoder not on a detent position 🤞 Encoder position changes are ignored on startup until it is on a detent. |
|
Repeat testing on T16, TX16 and T20, no problems here, and I can't replicate the "on detent" issue so looks to be solved also. |
- detection of initial direction of encoder after startup - change of direction issue on radios with incorrectly wired encoder - handle all wiring variations (without needing special #defines) - handle the case when the radio is started with the encoder not on a detent position
Re-write rotary encoder logic and update Lvgl driver to fix:
May fix #3409
Candidate for 2.10.2