Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x9d): incorrect switch positions on main view #5094

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented May 31, 2024

Fixes #5092

Move 2nd column of switches back to right side of the display.

@pfeerick pfeerick added B&W Related generally to black and white LCD radios bug/regression ↩️ A new version of EdgeTX broke something labels Jun 1, 2024
@pfeerick pfeerick added this to the 2.10.2 milestone Jun 1, 2024
@pfeerick pfeerick changed the title fix(x9d): incorrect switch positions on main view for X9D radios. fix(x9d): incorrect switch positions on main view Jun 1, 2024
@pfeerick
Copy link
Member

pfeerick commented Jun 1, 2024

I'll go with that since I introduced that back in #3996 after you fixed it in the initial commit, but like with that commit it still fixes one problem and causes another... as the smaller switch view was supposed to look like this rather than split across two lines as this does now (if we want to keep the layout as it was in 2.9), with the open space on the right being used for the timers or LS. Having said that, I don't think the space is otherwise used, and looks too small to reserve for third timer, so may just have to stay as it is for now.

image

@pfeerick pfeerick merged commit fea402a into main Jun 1, 2024
44 checks passed
@pfeerick pfeerick deleted the philmoz/fix-x9d-main-view branch June 1, 2024 00:42
@philmoz
Copy link
Collaborator Author

philmoz commented Jun 1, 2024

X9D variants now match X9E layout on those views.

I can fix it to show a single row for the X9D version if you want.

X9E:
screenshot_x9e_3_2 10

X9D:
screenshot_x9d+_3_2 10fix

@pfeerick
Copy link
Member

pfeerick commented Jun 1, 2024

Personally I don't care either way... and I don't think there is any use for the remaining screen space, especially as all of that space is needed when the X9E is fully loaded... so unless you have a burning desire to change it, lets leave it until someone wants it changed, or we come up with a different UI layout...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios bug/regression ↩️ A new version of EdgeTX broke something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switches position on screen and flight mode
2 participants