fix(cpn): T-Pro function switches

[elecpower]

Fixes #4898

Note: I have not tested on hardware or simulator

[3djc]

No no no, the customisable (function) switches name need to be displayed as SWx for end users, on radio too (and always have been, sorry if I have been unclear).

The issue with 'alias' names is only those where used in yaml before 2.10

[elecpower]

So the only change needs to be in yaml_rawswitch.cpp decode to map SE -> SW1 thru SJ - SW6 for T-Pro radios only. The encode yaml is SW1 thru SW6. Correct?

[3djc]

In 2.9, customisable switches are displayed SW1 to SW6 on radio, and encoded in yaml as SE to SJ for TPro
In 2.10, customisable switches are displayed SW1 to SW6 on radio, and encoded in yaml as SW1 to SW6 for TPro

I belive TPro was the only radio with customisable switches in 2.9

[elecpower]

@3djc hopefully I have got it right this time

[3djc]

2.9.4:

customFn: 
   0:
      swtch: "SE2"
      func: OVERRIDE_CHANNEL
      def: "0,0,0"
   1:
      swtch: "SJ2"
      func: OVERRIDE_CHANNEL
      def: "0,0,0"

Opening in 2.10 companion (this PR)
Read perfectly:

Save to radio:

customFn:
  0:
    swtch: SW12
    func: OVERRIDE_CHANNEL
    def: 0,0,0
  1:
    swtch: SW62
    func: OVERRIDE_CHANNEL
    def: 0,0,0

Open with 2.10rc3

PERFECT !

[arkarkark]

This isn't going to conflict with the t-pro v2 having extra switches between the triggers and the pots which it calls SE and SF, right? the v1 t-pro doesn't have these switches.

[pfeerick]

It shouldn't no. The TPro V1 actually does have those switches, but they default to None as they are very hard trigger on the V1 (the trim caps go in too far making it hard to press) and IIRC was never advertised as a feature.

[pfeerick]

A read/write cycle is working fine here on TPro V1 hardware also on Windows with a more elaborate setup. No customisable switches were harmed 🤭