Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add remaining/elapsed display on BW telem topbar #3871

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

3djc
Copy link
Collaborator

@3djc 3djc commented Jul 28, 2023

While @pfeerick was couting sheeps, request : #3856 (comment)

Handles remaining/elapsed display on BW telemetry screen topbar and move to HH:MM:SS format

@lightbulbjim
Copy link

Would it make more sense to do:

if timer < 60 minutes
MM:SS
else
HH:MM
end

This matches the format of both the home screen and voice callouts.

@pfeerick
Copy link
Member

Thanks JC :)

My only concern then would be that it wouldn't be quite as... obvious? ... that one is the time, and the other not the time (although the same could be said if it is counting up, and active 🤭 )

I'll let the PR author case the deciding vote 😆

@pfeerick pfeerick added UX-UI Related to user experience (UX) or user interface (UI) behaviour B&W Related generally to black and white LCD radios labels Jul 30, 2023
@3djc
Copy link
Collaborator Author

3djc commented Jul 30, 2023

My concern exactly. Because this is a screen designed to be read while you fly, you don't have the luxury to leave your eyes on this screen for a couple of seconds to see if right collum is counting quickly (hence MM:SS) or not. HH:MM:SS is unambigous imho. I had concider adding an arrow or something to show if remaining or actual was displayed, but dit not find one that wasn't confusing

@lightbulbjim
Copy link

Makes sense. Thanks!

@pfeerick pfeerick merged commit 159db76 into main Jul 31, 2023
36 checks passed
@pfeerick pfeerick deleted the 3djc/improve-time-telemtopbar branch July 31, 2023 01:22
@pfeerick pfeerick added this to the 2.9 milestone Jul 31, 2023
pfeerick added a commit that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants