Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some radio settings were overwritten or not applied #1787

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

raphaelcoeffic
Copy link
Member

  • fix default VCP configuration (was not applied)
  • fix internal module configuration (was always overwritten with default module)

@pfeerick pfeerick added the bug 🪲 Something isn't working label Apr 2, 2022
@pfeerick pfeerick added this to the 2.7 milestone Apr 2, 2022
@pfeerick
Copy link
Member

pfeerick commented Apr 2, 2022

Fixes both the VCP not being set to CLI issue on supported radios (i.e. TX16S, Zorro) we were talking about. I was going to say it also fixes the internalModule == OFF issue when upgrading, but for me at least, this had basically no effect - since it was correctly set when going from 2.5 -> 2.7rc1. I think that culprit is somewhat intermittent, but this might at least catch one more instance of it not being set.

@pfeerick pfeerick merged commit d8075cb into main Apr 2, 2022
@pfeerick pfeerick deleted the fix-radio-defaults branch April 2, 2022 11:28
@TheIsotopes
Copy link
Contributor

@raphaelcoeffic Is it normal that VCP after a change (e.g. OFF) is always set back to CLI?
found on TX16S and Zorro

@raphaelcoeffic
Copy link
Member Author

@raphaelcoeffic Is it normal that VCP after a change (e.g. OFF) is always set back to CLI?
found on TX16S and Zorro

Yes, as designed. The point being here that ELRS relies on CLI for passthrough flashing. So if it is OFF, it will go back to default, which is CLI.

@pfeerick
Copy link
Member

pfeerick commented Apr 2, 2022

We could possibly make it more specific though? IF Internal Module == CRSF, default it back to CLI if off/not set? As it's not needed for MULTI... or is that because you're thinking we would be update MPM firmware through CLI in the future also? It's not like it's really a problem since that is/was the primary use for VCP (or as debug).

@raphaelcoeffic
Copy link
Member Author

I would really like being able to update the MPM via passthrough as well! And it should even be possible in fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants