Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include commit Number in About Companion page #1415

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Include commit Number in About Companion page #1415

merged 3 commits into from
Jan 12, 2022

Conversation

Nerenye
Copy link
Contributor

@Nerenye Nerenye commented Jan 11, 2022

Fixes #1405

Summary of changes:

Define GIT_STR in version.h.in as in radio FW (stamp.h.in)
display git Commit number in mainwindow.cpp (About Companion Page) including a link to the commit on github
display a link to open a new request/ issue

@Nerenye
Copy link
Contributor Author

Nerenye commented Jan 11, 2022

image

@Nerenye
Copy link
Contributor Author

Nerenye commented Jan 11, 2022

Oh and i bumped the Copyright year to 22

@pfeerick pfeerick added companion Related to the companion software enhancement ✨ New feature or request labels Jan 11, 2022
@pfeerick pfeerick added this to the 2.6 milestone Jan 11, 2022
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto! Thank you! 😍

@pfeerick pfeerick merged commit db39240 into EdgeTX:main Jan 12, 2022
@pfeerick pfeerick modified the milestones: 2.6, 2.7 Jan 14, 2022
pfeerick pushed a commit that referenced this pull request Jan 14, 2022
#1415)

* Include Git Commit Number into about popup and refferencing to the github commit via link

* Add Link to Create New Issue on Github

* Add Link to Create New Issue on Github
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
companion Related to the companion software enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Companion should display commit number of compiled binary.
2 participants