-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Companion hardware internal module continued #1342
Conversation
Internationalization is for translations - the code uses regexps to look for dialogs with matching window title. To truly test need someone running non-english language to test. If regexp doesn't work I will have to take a different tact. |
oakey dokey... I'll switch languages and report back tomorrow ;) |
Although this may not be a true test, switching the menu language to French is a test fail. Using menu language System Default on a French OS may work but I suspect the character sets screw with regexp even though the search string should be translated. So looks like another method required. |
Reworked to avoid translation issues |
Looks good so far - with system languages French, German and Chinese in Windows 10, it worked perfectly. And also when using the menu to change the language back. |
Any particular reason "Off" is not an option in Companion for Radio => Hardware settings (when it is on radio)? Also isn't a option for profile def internal module setting. |
Either @raphaelcoeffic or I erred. Anyway I'll sort out the shared list. |
* Add ability to undo hardware internal module change * Add internal module protocol check on model edit * Event driven check and update of all models * Fix model edit dialog searches * Add OFF to list of internal modules * Fix internal module protocol list issue #1382
Summary of changes:
(requires internationalization testing)(requires internationalization testing)