Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BattCheck - 8 cell and li-ion #76

Merged

Conversation

offer-shmuely
Copy link
Contributor

No description provided.

@offer-shmuely offer-shmuely changed the title Shmuely/batheck 8 cell and li ion BattCheck - 8 cell and li-ion Sep 12, 2022
@mha1
Copy link

mha1 commented Sep 12, 2022

Hi, I just tested this version. Maybe I am doing it wrong but I can't set/reset the Lithium_Ion options. It is not in the widget options menu list or scrolling further down is not possible.

image

The Lithium_Ion option should be there, right?

local _options = { { "Sensor" , SOURCE, 0 }, -- default to 'Cels' { "Color" , COLOR , YELLOW}, { "Shadow" , BOOL , 0 }, { "LowestCell" , BOOL , 1 }, -- 0=main voltage display shows all-cell-voltage, 1=main voltage display shows lowest-cell { "Lithium_Ion" , BOOL , 0 }, -- 0=LIPO battery, 1=LI-ION (18650/21500) }

@offer-shmuely
Copy link
Contributor Author

the li-ion should be there
I am developing it in 2.7.1

image

but it look working on 2.8 from the PR
image

@mha1
Copy link

mha1 commented Sep 12, 2022

That is strange. I'll do a clean setup and try again

@mha1
Copy link

mha1 commented Sep 13, 2022

Started from scratch using #76's BattCheck file. All good, must have been doing something wrong. My apologies for the confusion.

image

@pfeerick pfeerick merged commit 834f288 into EdgeTX:master Sep 14, 2022
@mha1
Copy link

mha1 commented Sep 27, 2022

@offer-shmuely Hi Offer, Peter merged the 8 cell radio part into main. I tested BattCheck against the current main for radio and companion ok. It would be great if you could update c320x480 and c480x320 also to handle 8 cells.

@offer-shmuely offer-shmuely deleted the shmuely/batheck_8_cell_and_li_ion branch September 27, 2022 18:39
@offer-shmuely
Copy link
Contributor Author

How can i test the 480x320, what radio it is in the companion?

@mha1
Copy link

mha1 commented Sep 27, 2022

This is what I found:

c480x320.zip (480x320 pixel landscape orientation color screen radios);

  • Flysky PL18
  • Flysky Paladin EV (PL18EV)

c320x480.zip (320x480 pixel Portraits orientation color screen radios):

  • Flysky Nirvana NV14

@mha1
Copy link

mha1 commented Sep 27, 2022

https://github.com/EdgeTX/edgetx/wiki/Flashing-EdgeTX-to-Flysky-PL18-or-Paladin-EV

I think there is no rush for 480x320 as the PL18 support may no be fully implemented.

320x480 NV14 is supported and working. I have it running in companion,

@pfeerick
Copy link
Member

I think there is no rush for 480x320 as the PL18 support may no be fully implemented.

It's in development still, i.e. not supported yet. ;)

@offer-shmuely
Copy link
Contributor Author

updated the BattCheck for NV14

  • NV14 BattCheck: support li-ion battery
  • NV14 BattCheck: support 8 cell
  • NV14 BattCheck: voltage 2 digit precesion
  • NV14 BattCheck: fix layout issues

PR: #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants