More intuitive folder structure naming #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bw128x64 (old taranis-x7) * bw212x64 (old taranis-x9) * c480x272 (old horus) * c320x480 (old NV14, applies also to EL18)
|
Looks good. Needs co-ordination with both Flasher and Buddy to ensure they don't get broken due to the change in names. Or at least confirmation they are both exclusively using |
|
@CoderElectronics and @freshollie both confirmed |
|
The names are actually hard-coded into Flasher so this actually broke Flasher's ability to SD card prep. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, instead of
taranis-x7,taranis-x9,horusandnv14, uses the following subfolder naming:bw128x64(old taranis-x7)bw212x64(old taranis-x9)c480x272(old horus)c320x480(old NV14, applies also to EL18)