Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(color): model presets #127

Merged
merged 29 commits into from
Apr 4, 2024

Conversation

offer-shmuely
Copy link
Contributor

No description provided.

@pfeerick
Copy link
Member

pfeerick commented Feb 4, 2024

Ready to go in now?

@offer-shmuely
Copy link
Contributor Author

I need more feedback...

@pfeerick
Copy link
Member

pfeerick commented Apr 2, 2024

Shall we just merge and keep adding to this?

@offer-shmuely
Copy link
Contributor Author

We can do that.
We need more suggestions to be added, i hope the community will supply some.

did you played with what implemented currently?

@pfeerick
Copy link
Member

pfeerick commented Apr 3, 2024

Yes, and it looks really good.

My only real 2c of input would be that, generally, since you have long enter to confirm for saving settings, I'm not sure you need to long RTN to exit - short RTN would seem to be enough.

For the dual rates... I think you may find some people will want just two rates ... i.e. you might remember hawk from the other day, who does two rates on SF... so it may be worth considering a way to implement that in the future.

Specifically for the persistent model timer... I think you forgot to make it actually persist? But perhaps the sticking point there was how to trigger it, so it became more an 'adjust' option? Also, it would be nice to be able to choose the timer, as for whatever reason I always use timer 3 as my persistent one. 😆 🤷

@offer-shmuely
Copy link
Contributor Author

Thanks for the good advice :-)

short RTN would seem to be enough.

done

persistent model timer

I think you forgot to make it actually persist.

correct, fixed, the line was still commented

it would be nice to be able to choose the timer

done.

as for whatever reason I always use timer 3 as my persistent one

I do the same as well

dual rates...

is there an option to know if the switch is 2 pos, or 3 pos?
if there is, I can do that as well

@pfeerick
Copy link
Member

pfeerick commented Apr 4, 2024

Not that I am aware of. It's not going to be "simple" to implement, which is why it's only a thought for later. i.e. sure, you could have a drop down that says how many rates(2/3)... but then for this to work I think you would have to make it so you can pick the switch position for each rate... and also include the not (!) state so you could use a 3POS for 2 rates. Yes, that is more ... customisable (since you can also choose which rate is toggled where... but we're trying to make things simpler, aren't we? 🤣 Or maybe that sort of thing is a more advanced dual rates preset?

I'll merge this now, as I want to try and get it some more visibility (i.e. as part of ETX v2.10 - it will get mention in the next RC announcement as well as final release) and get more feedback and ideas for it.

@pfeerick pfeerick changed the title model presets feat(color): model presets Apr 4, 2024
@pfeerick pfeerick merged commit 02d09b8 into EdgeTX:master Apr 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants