Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

implemented typewriter effect using typewriter-effect package #1986

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

RohitYandigeri
Copy link
Contributor

@RohitYandigeri RohitYandigeri commented Oct 18, 2022

workerB

Fixes Issue

enhances the webpage

Changes proposed

Check List (Check all the applicable boxes)

  • [ x] My code follows the code style of this project.
  • [ x] My change requires changes to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [x ] All new and existing tests passed.
  • [ x] This PR does not contain plagiarized content.
  • [ x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

LinkFree.-.Google.Chrome.2022-10-18.14-05-29_Trim.mp4

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the large Pull request with more than 30 changed lines label Oct 18, 2022
@github-actions
Copy link
Contributor

Welcome @RohitYandigeri! Thank you so much for your first pull request!

@eddiejaoude
Copy link
Member

Thank you for the contribution 👍

Ideally you should raise an issue first to discuss the idea. TBH I am not a huge fan of the typewriter effect, I feel it is over used, plus it is not inclusive or accessible - but I am no expert in accessibility, @EmmaDawsonDev what do you think?

@RohitYandigeri
Copy link
Contributor Author

Thank you for the contribution 👍

Ideally you should raise an issue first to discuss the idea. TBH I am not a huge fan of the typewriter effect, I feel it is over used, plus it is not inclusive or accessible - but I am no expert in accessibility, @EmmaDawsonDev what do you think?

How about I build another more creative animation and it may look way cooler than this !

@EmmaDawsonDev
Copy link
Member

Any animation created also needs a way to pause, stop or hide it and you would also need to use the prefers reduced motion media query so that the animation doesn’t start for people who have it set to true

@RohitYandigeri
Copy link
Contributor Author

Any animation created also needs a way to pause, stop or hide it and you would also need to use the prefers reduced motion media query so that the animation doesn’t start for people who have it set to true

Can you explain me in more simple way what actually I should work upon ?

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@eddiejaoude eddiejaoude merged commit a734367 into EddieHubCommunity:main Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
large Pull request with more than 30 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants