Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Dark mode toggle is not reachable with keyboard navigation #1927

Closed
EmmaDawsonDev opened this issue Oct 8, 2022 · 3 comments
Closed

Dark mode toggle is not reachable with keyboard navigation #1927

EmmaDawsonDev opened this issue Oct 8, 2022 · 3 comments
Assignees
@vasucp1207
Labels
🛠 goal: fix undefined

Comments

@EmmaDawsonDev
Copy link
Member

Description

image

The toggle button in the header is unreachable with the tab key when navigating by keyboard. It should be possible to reach it and activate it just by tabbing through the site.

Screenshots

No response

Additional information

No response
@EmmaDawsonDev EmmaDawsonDev added the 🛠 goal: fix undefined label Oct 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2022

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@vasucp1207
Copy link
Contributor

Hey, @EmmaDawsonDev I want to work on this issue

@vasucp1207 vasucp1207 mentioned this issue Oct 8, 2022
Merged
eddiejaoude pushed a commit that referenced this issue Nov 5, 2022
@vasucp1207
fix: dark mode toggle reachable with keyboard (#1931)
80fd19d 
* Fixing Dark mode toggle is not reachable with keyboard navigation

* Replacing a tag with the button Issue #1927

* Replacing a tag with the button Issue #1927

* Fix margins due to a tag changing to button

Co-authored-by: vasu <vasu@vasus-MacBook-Air.local>
@eddiejaoude
Copy link
Member

The new version of LinkFree is out, I will close this issue, feel free to create a new issue for the new version if still relevant

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vasucp1207 vasucp1207

Labels
🛠 goal: fix undefined
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eddiejaoude @EmmaDawsonDev @vasucp1207