This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Created a FallbackImage component to handle broken images #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
Panquesito7
added
✨ goal: improvement
eddiejaoude
approved these changes
Oct 19, 2022
eddiejaoude
reviewed
Oct 19, 2022
| import { useState } from "react"; | ||
| import Image from "next/image"; | ||
|
|
||
| export const FallbackImage = ({ src, alt, fallback = "A A", ...rest }) => { |
There was a problem hiding this comment.
I think a default export will be better here, but it is not a blocker to get this merged in
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
I noticed that some of the profile images are broken, so the alt text is being used instead of an image which doesn't look very nice. I created a simple custom
FallbackImagecomponent which uses the NextJS Image component and all it's powers, but it handles broken images more gracefully and it shows a dynamic SVG image based on a given prop.I used DiceBear Avatars to generate dynamic SVGs for the broken images.
Two files had broken profile image issue, [username].js and UserPreview.js . I edited both of these files and switched the default NextJS Image component with the FallbackImage component.
Check List (Check all the applicable boxes)
Screenshots
before changes :
after changes :