Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmlchange: Add documentation for setting values with commas #4657

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

jgfouca
Copy link
Contributor

@jgfouca jgfouca commented Aug 8, 2024

This has come up a few times and confused our users.

Test suite: None, just a docs change
Test baseline:
Test namelist changes:
Test status: bit for bit

User interface changes?:

Update gh-pages html (Y/N)?:

Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out.

@klindsay28
Copy link
Collaborator

Spelling correction from the peanut gallery...
alternaltive -> alternative

@jgfouca
Copy link
Contributor Author

jgfouca commented Aug 8, 2024

Thanks, @klindsay28 . Fixed.

Copy link
Collaborator

@jasonb5 jasonb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgfouca jgfouca merged commit 9894678 into master Aug 9, 2024
7 checks passed
@jgfouca jgfouca deleted the jgfouca/xmlchange_commas branch August 9, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants