-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes DAE.ww3a.ADWAV from cime_developers #4474
Conversation
Removed from E3SM with E3SM-Project/E3SM@352f737. |
@sbrus89 did you remove those just to clean up? If we need that case in cime_developers, we could probably add it back. |
@rljacob, yes. I removed the ww3a grids as a clean-up since we weren't planning to support them. We can add them back in if necessary. |
@rljacob I'm not sure if it's needed. @jgfouca are we fine to remove this or just replace the grid? Looks like CESM had it disabled cime/CIME/tests/test_sys_full_system.py Lines 44 to 50 in 02fad90
Lines 212 to 215 in 02fad90
|
@jasonb5 , we don't have any other DAE tests, so maybe just use a more common grid? |
This raises the question of whether the DAE test type is needed. E3SM has never used it. |
We are currently at a stall in the development of that component, however we do have plans to bring it in. |
This will leave DAE untested, but I'm fine with that. |
Remove DAE.ww3a.ADWAV from cime_developers. E3SM has removed
the ww3a grids, which caused this to fail.
Test suite: ./scripts/create_test cime_developer
Test baseline: n/a
Test namelist changes: n/a
Test status: n/a
Fixes n/a
User interface changes?: N
Update gh-pages html (Y/N)?: N