if the config_machines.xml file cannot be found give a meaningful error #4469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnlevy1981
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
For testing, I checked out cesm2_3_beta15 and ran ./manage_externals/checkout_externals cime pop cmeps cdeps ww3; I then tried to run ./create_newcase --compset C --res T62_g17 --case ../../cases/C.test out of cime/scripts.
Out of the box, the error I got matched what is reported in #4468 (I don't think I included the full traceback, but the Schema validity test fails line is what helped us realize we were missing ccs_config):
Compset longname is 2000_DATM%NYF_SLND_DICE%SSMI_POP2_DROF%NYF_SGLC_WW3
Compset specification file is /glade/work/mlevy/codes/CESM/cesm2_3_beta15.test/components/pop//cime_config/config_compsets.xml
Automatically adding SESP to compset
Schema validity test fails for /glade/work/mlevy/codes/CESM/cesm2_3_beta15.test/ccs_config/config_grids_nuopc.xml
Traceback (most recent call last):
File "/glade/work/mlevy/codes/CESM/cesm2_3_beta15.test/cime/scripts/./create_newcase", line 18, in <module>
_main_func()
File "/glade/work/mlevy/codes/CESM/cesm2_3_beta15.test/cime/CIME/scripts/create_newcase.py", line 422, in _main_func
case.create(
File "/glade/work/mlevy/codes/CESM/cesm2_3_beta15.test/cime/CIME/case/case.py", line 2419, in create
self.configure(
File "/glade/work/mlevy/codes/CESM/cesm2_3_beta15.test/cime/CIME/case/case.py", line 1289, in configure
grids = Grids(gridfile, comp_interface=driver)
File "/glade/work/mlevy/codes/CESM/cesm2_3_beta15.test/cime/CIME/XML/grids.py", line 34, in __init__
self._version = self.get_version()
File "/glade/work/mlevy/codes/CESM/cesm2_3_beta15.test/cime/CIME/XML/generic_xml.py", line 434, in get_version
version = self.get(self.root, "version")
File "/glade/work/mlevy/codes/CESM/cesm2_3_beta15.test/cime/CIME/XML/generic_xml.py", line 200, in get
return node.xml_element.get(attrib_name, default=default)
AttributeError: 'NoneType' object has no attribute 'xml_element'
With the branch this PR uses, the error is
Compset longname is 2000_DATM%NYF_SLND_DICE%SSMI_POP2_DROF%NYF_SGLC_WW3
Compset specification file is /glade/work/mlevy/codes/CESM/cesm2_3_beta15.test/components/pop//cime_config/config_compsets.xml
Automatically adding SESP to compset
ERROR: ERROR: grid file not found /glade/work/mlevy/codes/CESM/cesm2_3_beta15.test/ccs_config/config_grids_nuopc.xml
which is much better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives a meaningful error if config_grids.xml or config_machines.xml cannot be found.
Test suite:scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #4468
User interface changes?:
Update gh-pages html (Y/N)?: