Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the account remove and add support for slurm #4466

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

jedwards4b
Copy link
Contributor

Improve the account remove function and add support for slurm.

Test suite:
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #4465

User interface changes?:

Update gh-pages html (Y/N)?:

@jedwards4b jedwards4b requested a review from jgfouca July 24, 2023 19:38
@jedwards4b jedwards4b self-assigned this Jul 24, 2023
Copy link
Contributor

@jgfouca jgfouca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR! I think the logic in the first if statement may be off
if (A or B and C)
The and has the higher precedence, so B and C is evaluated first.

I think you want
if (A or B) and C

@jedwards4b
Copy link
Contributor Author

fixed

@jedwards4b jedwards4b merged commit a8e8e79 into ESMCI:master Jul 24, 2023
9 checks passed
@jedwards4b jedwards4b deleted the refine_account_remove branch July 24, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e3sm batch commands not working after CIME update
2 participants