1pt grid update

[jedwards4b]

Instead of requiring a netcdf domain file here we allow single point cases to just set the lat and lon values in PTS_LAT and PTS_LON. This requires an update of the grids schema to v2.2. This schema was tested with cpl7 which continues to use domain files and with cmeps which will use the new PTS_LAT and PTS_LON. Depends on cmeps ESCOMP/CMEPS#160

Test suite: scripts_regression_tests.py SMS_D_Ly6_Mmpi-serial.1x1_smallvilleIA.IHistClm45BgcCropQianRs.cheyenne_intel.clm-cropMonthOutput
Test baseline: ctsm5.1.dev019
Test namelist changes:
Test status: bit for bit

Fixes

User interface changes?:

Update gh-pages html (Y/N)?:

Code review:

[ekluzek]

I really like this idea as it will be so much easier to not have to create domain files for single point grids. I only have one suggestion that when PTS_LAT/PTS_LON is used in this context that PTS_MODE be set to something to indicate that's it's not the standard mode that expects domain files nor the SCAM PTS_MODE=TRUE which works differently.

[ekluzek]

This looks really good, and I love this idea as it will simplify running with single point grids.

I do think that the mode of running without domain files for a single point should be a different option for PTS_MODE. Issue #3876 covers this point. So hopefully we'll hear from others if they agree with that or not.

The other thing though that absolutely does need to be done is to update the description of PTS_MODE, PTS_LAT, and PTS_LON as they currently only describe their use in the SCAM type context where a global domain file is being read in and the closest PTS_LAT, PTS_LON to it is found.

[jedwards4b]

@ekluzek PTS_MODE has been removed entirely from the nuopc interface, we now only use the
existence of the domain file to determine scam or 1pt. Further the description of these variables for mct
hasn't changed and the description for nuopc has been updated in the cooresponding PR: ESCOMP/CMEPS#160

[ekluzek]

Ahhh, OK, I needed to also look at the CMEPS PR. OK, I think that removes all of my objections then possibly including the issue. Right now I don't get how you can remove PTS_MODE for SCAM since it needs both a domain file and setting of PTS_LAT/PTS_LON. But, we talk in less than an hour so you can likely explain it then.

[mvertens]

@ekluzek I am working on slightly modifying this - please don't review more until an upcoming CMEPS/CDEPS/CIME PRs are there.

…

On Thu, Mar 4, 2021 at 1:11 PM Erik Kluzek ***@***.***> wrote: Ahhh, OK, I needed to also look at the CMEPS PR. OK, I think that removes all of my objections then possibly including the issue. Right now I don't get how you can remove PTS_MODE for SCAM since it needs both a domain file and setting of PTS_LAT/PTS_LON. But, we talk in less than an hour so you can likely explain it then. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#3868 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4XCEYAPTLYGTUCRMHJVA3TB7SQ3ANCNFSM4YJAZO5Q> .

-- Mariana Vertenstein CESM Software Engineering Group Head National Center for Atmospheric Research Boulder, Colorado Office 303-497-1349 Email: mvertens@ucar.edu

[jedwards4b]

superceeded