Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional KPP output when TEST=True #104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add additional KPP output when TEST=True #104

wants to merge 1 commit into from

Conversation

mnlevy1981
Copy link
Collaborator

Fixes #103

Things are starting to get cluttered, as there are now blocks for TEST == True and TEST == False nested inside the existing blocks for USE_CFC_CAP == "TRUE" and USE_CFC_CAP == "FALSE". I may eventually open up an issue ticket to discuss possible options for making diag_table.yaml more extensible, because it's going to get downright ugly when we bring in MARBL and need to support USE_MARBL_TRACERS == "TRUE" and USE_MARBL_TRACERS == "FALSE" as well.

@mnlevy1981
Copy link
Collaborator Author

Note that I'm pretty sure this will cause the CESM test suite to fail the BASELINE test because there are six new variables that will not be found in the existing baselines.

@alperaltuntas
Copy link
Member

I agree that that the format of diag_table.yaml should be rethought.

@gustavo-marques
Copy link
Collaborator

@mnlevy1981, can you please solve these conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavo-marques gustavo-marques gustavo-marques approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add additional KPP terms to diagnostics
3 participants
@mnlevy1981 @alperaltuntas @gustavo-marques