-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always avoid generating dynamic landunit adjustments for glacier area #472
Always avoid generating dynamic landunit adjustments for glacier area #472
Conversation
The main motivation is: If we change the title of a bug, then some context can be lost for the original bug report. It could help if the summary - something like the title - were repeated in the initial bug report, so that the summary would remain intact even if the title is changed.
…to release-clm504ndepupdate
…to release-clm504ndepupdate
changes in the first timestep of a startup or hybrid run - not just for cold start or interpolated start. This is the change in ctsm1.0.dev007. i
We need to get confirmation from @dlawrenncar and possibly others before bringing this to the release branch. The main thing I'm unsure of is what simulations/configurations we are / are not allowed to change answers for on the release branch. |
@billsacks, we are changing answers due to changes in forcing with simulations right now. We are also changing answers due to updates in initial conditions as well. This change only effects answers at startup, so is smaller than either of those things. As a matter of fact with my testing many cases appear identical, I'm not even sure if there are tests that DO change answers. My understanding of Gokhan's statement "I am comfortable with this path. That is i) having virtual columns on with the land initial conditions coming from a 1-year additional land simulation with identical layout as in the coupled simulation for the land model and ii) when this option is off, the land initial conditions would still produce bfb results....." is that this PR is REQUIRED to satisfy his requirements, since the simulations that will be done will be done with release branch tags. Am I missing something? |
My understanding is the same as Erik's, but I could be misunderstanding
something as it seems that there are a lot of subtleties here.
…On Mon, Aug 6, 2018 at 10:28 AM, Erik Kluzek ***@***.***> wrote:
@billsacks <https://github.com/billsacks>, we are changing answers due to
changes in forcing with simulations right now. We are also changing answers
due to updates in initial conditions as well. This change only effects
answers at startup, so is smaller than either of those things. As a matter
of fact with my testing many cases appear identical, I'm not even sure if
there are tests that DO change answers.
My understanding of Gokhan's statement "I am comfortable with this path.
That is i) having virtual columns on with the land initial conditions
coming from a 1-year additional land simulation with identical layout as in
the coupled simulation for the land model and ii) when this option is off,
the land initial conditions would still produce bfb results....." is that
this PR is REQUIRED to satisfy his requirements, since the simulations that
will be done will be done with release branch tags. Am I missing something?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#472 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AUAcVOX7mGKidSaA57dUl363zu403996ks5uOG67gaJpZM4Vv0fs>
.
|
…to release-clm504ndepupdate
Only two tests show change in answers ERI_N2_Ld9.f19_g17.I2000Clm50BgcCrop.cheyenne_intel.clm-default There's also two single-point tests (that are in the share queue and CISL says the share queue has problems) that I'm having trouble with. |
Always avoid generating dynamic landunit adjustments for glacier area
Always avoid generating dynamic landunit adjustments for glacier area
changes in the first timestep of a startup or hybrid run - not just for
cold start or interpolated start.
This is the change in ctsm1.0.dev007.
Specific notes
Contributors other than yourself, if any: @billsacks
CTSM Issues Fixed (include github issue #): #340
Are answers expected to change (and if so in what way)?
In general, can have answer changes in startup / hybrid tests that do not use init_interp, and use CISM (even NOEVOLVE), due to:
different PE layout in new case vs. the one that generated the finidat (roundoff-level diffs)
different glacier area on finidat file vs. what's in CISM (greater than roundoff-level diffs)
Any User Interface Changes (namelist or namelist defaults changes)? None
Testing performed, if any: None so far Testing was done on master