-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid glacier dynamic landunit adjustments in first time step #470
Conversation
Always avoid generating dynamic landunit adjustments for glacier area changes in the first timestep of a startup or hybrid run - not just for cold start or interpolated start. See discussion in ESCOMP#340 for rationale. Fixes ESCOMP#340
@ekluzek I'm feeling like we really want to get this on master soon. What I'm not sure of is whether we want to bring this to the release branch. I did the same thing here as for the changes in my last tag: started a branch off of dev004 then merged in master before doing testing (so hopefully this makes things easier to bring this to the release branch if desired). I'll talk to you, @dlawrenncar and @olyson about the question of whether this should go on the release branch on Wednesday. But if you get this message today and want to give me the go-ahead to bring it to master, I'll bring it to master today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is simple enough, so should be approved.
The one comment I have are about variables that predate this change. is_cold_start and is_interpolated_start. I'm wondering if instead of having several logical variables that have to be coordinated, if it should be a single variable that has a few valid options. Something like: start_type = 'COLD', 'INTERPOLATED', 'RESTART'. But, that's a comment that essentially predates this PR, hence we should think about it as a clean-up step rather than a change here. |
Avoid glacier dynamic landunit adjustments in first time step Always avoid generating dynamic landunit adjustments for glacier area changes in the first timestep of a startup or hybrid run - not just for cold start or interpolated start. See the detailed discussion in #340 for rationale. Merges PR #470 Fixes #340
Avoid glacier dynamic landunit adjustments in first time step Always avoid generating dynamic landunit adjustments for glacier area changes in the first timestep of a startup or hybrid run - not just for cold start or interpolated start. See the detailed discussion in ESCOMP#340 for rationale. Merges PR ESCOMP#470 Fixes ESCOMP#340
Description of changes
Always avoid generating dynamic landunit adjustments for glacier area changes in the first timestep of a startup or hybrid run - not just for cold start or interpolated start. See discussion in #340 for rationale.
Specific notes
Contributors other than yourself, if any: none
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? YES
In general, can have answer changes in startup / hybrid tests that do not use init_interp, and use CISM (even NOEVOLVE), due to:
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed, if any: Ran full aux_clm test suite