Remove include_user_mods from matrixcnOn testmod

[samsrabin]

Should avoid unnecessary levels of history writing.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

• Resolves matrixcnOn testmod shouldn't include default testmod #2814.

Are answers expected to change (and if so in what way)? Only for our tests.

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: None yet.

[slevis-lmwg]

@samsrabin thank you for this work. I included one or two separate questions to my review, and here is another:
Did I understand correctly that the motivation for this PR is the reduction of history output when running matrixcn tests? If so, I missed which of your changes accomplishes that.

[samsrabin]

@samsrabin Did I understand correctly that the motivation for this PR is the reduction of history output when running matrixcn tests? If so, I missed which of your changes accomplishes that.

Removing the include_user_mods file from the test means that the default outputs no longer overwrite outputs specified by earlier test mods. For example, in LCISO_Lm13.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-ciso_monthly--clm-matrixcnOn_ignore_warnings, it should have been saving monthly (the ciso_monthly test mod) but was actually being saved at much higher frequency (because matrixcnOn_ignore_warnings was after ciso_monthly in the test name). That test goes from 30 to 3 GB after this change.

[slevis-lmwg]

@samsrabin Did I understand correctly that the motivation for this PR is the reduction of history output when running matrixcn tests? If so, I missed which of your changes accomplishes that.

Removing the include_user_mods file from the test means that the default outputs no longer overwrite outputs specified by earlier test mods. For example, in LCISO_Lm13.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-ciso_monthly--clm-matrixcnOn_ignore_warnings, it should have been saving monthly (the ciso_monthly test mod) but was actually being saved at much higher frequency (because matrixcnOn_ignore_warnings was after ciso_monthly in the test name). That test goes from 30 to 3 GB after this change.

Thank you, I had not realized this difference in behavior from moving "default" to the test name.

[slevis-lmwg]

Approving.

[samsrabin]

@samsrabin Did I understand correctly that the motivation for this PR is the reduction of history output when running matrixcn tests? If so, I missed which of your changes accomplishes that.

Removing the include_user_mods file from the test means that the default outputs no longer overwrite outputs specified by earlier test mods. For example, in LCISO_Lm13.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-ciso_monthly--clm-matrixcnOn_ignore_warnings, it should have been saving monthly (the ciso_monthly test mod) but was actually being saved at much higher frequency (because matrixcnOn_ignore_warnings was after ciso_monthly in the test name). That test goes from 30 to 3 GB after this change.

Thank you, I had not realized this difference in behavior from moving "default" to the test name.

Well technically it's not moving default to the test name that does it; it's removing the include_user_mods file. Every test mod in a test name gets its user_nl_clm appended, in order, to create the one used by the test. So if default's user_nl_clm (via matrixcnOn) comes after ciso_monthly's, then if both test mods set something, default's will be the one used.