Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update snow overburden compaction parameter #250

Conversation

lvankampenhout
Copy link
Contributor

Snow viscosity for dry compaction was changed around 2016 and is described in more detail by (Van Kampenhout et al., 2017). Basically we adopted the viscosity expression from Crocus (Vionnet et al, 2012) and changed one parameter (c_eta) to better fit firn core observations. The original value of the c_eta parameter in Vionnet2012 is 250 kg/m3. In our study we tested different values (like 450) before arriving at the final value of 358 kg/m3. In this commit we change the value of c_eta from 450 to 358 kg/m3.

Snow viscosity for dry compaction was changed in 2016 and is described in more detail by (Van Kampenhout et al., 2017). Basically we adopted an expression from Crocus (Vionnet et al, 2012) and changed one parameter (c_eta) to better fit firn core observations. The original value of the c_eta parameter in Vionnet2012 is 250 kg/m3. In our study we tested different values (like 450) before arriving at the final value of 358 kg/m3. In this commit we change the value of c_eta from 450 to 358 kg/m3.
@lvankampenhout
Copy link
Contributor Author

FYI, this commit will be answer-changing but only to a very minor degree. Overburden compaction is a relatively weak force that only plays a dominant role in thick snow packs (> 1 m)

@billsacks
Copy link
Member

@lvankampenhout thanks for this. Have you run this by @dlawrenncar or others to determine the timing of bringing this to master? I'm particularly wondering if this is supposed to make it into CESM2, or if this is post-CESM2. If you haven't talked with @dlawrenncar about it yet, then I'm guessing this change will come in post-CESM2, since science is supposed to basically be frozen at this point.

Also, assuming this is for post-CESM2: We'll also want to consider pulling this out to a namelist parameter, so that its value can remain as is for CLM5.0 physics, but change for future physics versions.

@dlawrenncar
Copy link
Contributor

That's correct. This should be a post-CESM2 change.

@ekluzek ekluzek added priority: low Background task that doesn't need to be done right away. type: enhance - science labels Feb 2, 2018
@ekluzek ekluzek added this to the future milestone Feb 2, 2018
@lvankampenhout
Copy link
Contributor Author

OK, post-release is fine by me. In the Tech Note I wrote c_eta = 358 though (the new value) is that a problem? In that case we may want to change that to 450 to make it consistent to the code.

@billsacks
Copy link
Member

billsacks commented Feb 3, 2018 via email

lvankampenhout added a commit to ESCOMP/ctsm-docs that referenced this pull request Feb 5, 2018
overburden compaction parameter c_eta = 450 kg/m3 in the code.
This should have been 358 kg/m3 but it's too late to make that change now,
this is post-CESM2.
This commit updates the doc to make the doc consistent with the code.
also see: ESCOMP/CTSM#250
@lvankampenhout
Copy link
Contributor Author

OK I just made the change in the Tech note: ESCOMP/ctsm-docs@073a899

@billsacks
Copy link
Member

@lvankampenhout sorry for the silence here; we haven't forgotten about this. We just discussed it at our ctsm software meeting today, and felt that we'll want to

  • Introduce a new phys option (like clm4_5 and clm5_0, though we haven't figured out what to call the new one yet), triggered by compset

  • Pull this parameter out to namelist

  • Have the defaults for the parameter depend on the phys option (so clm5_0 would give the same science as before)

This might all take a while, so let us know if you need this sooner rather than later for any reason.

@lvankampenhout
Copy link
Contributor Author

Hi Bill,
No need to change this fast. For most runs I expect this will only make a marginal difference anyway (see my second post at the top). It's just a slight nuisance that right now the code is inconsistent with the paper that we published last year.

Personally I feel that pulling this out to the namelist is somewhat overkill, but if you guys decided this is desirable, I won't object that.

@billsacks billsacks added enhancement new capability or improved behavior of existing capability and removed type: enhance - science labels May 24, 2019
@ekluzek ekluzek removed this from the future milestone Aug 26, 2019
@adamrher
Copy link
Contributor

Leo, we are configuring the refined arctic simulations and am wondering if you still feel the c_eta value should be changed to 358 kg/m3. We are trying to improve the surface mass balance over greenland so if the 358 value is more realistic then I would favor this change.

@lvankampenhout
Copy link
Contributor Author

Hi Adam, making this change is not going to do much, as it's only a slight deviation on a parameter of compaction. You can still try if it's not not a hassle.

Much more important for melt are the parameters for snow initial grain size / refreezing grain size / grain growth rate / irreducible water content / bare ice albedo, all of which are only loosely constrained.

billsacks pushed a commit to billsacks/ctsm that referenced this pull request Mar 27, 2020
overburden compaction parameter c_eta = 450 kg/m3 in the code.
This should have been 358 kg/m3 but it's too late to make that change now,
this is post-CESM2.
This commit updates the doc to make the doc consistent with the code.
also see: ESCOMP#250
@ekluzek ekluzek added this to the ctsm5.1.0 milestone May 21, 2020
@wwieder
Copy link
Contributor

wwieder commented Aug 10, 2020

@Oleson, can you add this to the hard coded parameter bfb tag you're making.
Then we'll need to update to the value for ceta suggested here

@billsacks billsacks added PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete and removed PR status: later priority: low Background task that doesn't need to be done right away. labels Oct 6, 2020
@ekluzek ekluzek modified the milestones: ctsm5.1.0, ctsm5.2.0 Nov 12, 2020
@wwieder wwieder modified the milestones: ctsm5.2.0, ctsm5.1.0 Nov 12, 2020
@ekluzek
Copy link
Collaborator

ekluzek commented Jan 15, 2021

This work is actually completed now with our updated paramsfile that sets ceta to 358 in ctsm5.1. This is the case in ctsm5.1.dev021. So the equivalent of this is done. So I'm closing this.

@ekluzek ekluzek closed this Jan 15, 2021
fritzt pushed a commit to CESM-GC/CTSM that referenced this pull request May 19, 2021
overburden compaction parameter c_eta = 450 kg/m3 in the code.
This should have been 358 kg/m3 but it's too late to make that change now,
this is post-CESM2.
This commit updates the doc to make the doc consistent with the code.
also see: ESCOMP#250
glemieux added a commit to glemieux/ctsm that referenced this pull request Oct 8, 2021
Change ceta from 450 to 358 for CTSM5.1 See Leo VanKamenhout's work on this in
ESCOMP#250. Note, this is used in the PPE work.
See van Kampenhout et al. (2017).  Turn Medlyn on for PHS off for clm51 and clm50.
Make max CO2 partial pressure consistent in Photosynthesis.
Change surface datasets to only use 78PFT versions
Fix GSSUN and GSSHA history variables so now not just writing missing values.
Changes FATES to run with use_nitrif_dentrif=T by default. Change dynlakes test
to methane/use_nitrif_=T.
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this pull request Oct 8, 2021
Change ceta from 450 to 358 for CTSM5.1 See Leo VanKamenhout's work on this in
ESCOMP#250. Note, this is used in the PPE work.
See van Kampenhout et al. (2017).  Turn Medlyn on for PHS off for clm51 and clm50.
Make max CO2 partial pressure consistent in Photosynthesis.
Change surface datasets to only use 78PFT versions
Fix GSSUN and GSSHA history variables so now not just writing missing values.
Changes FATES to run with use_nitrif_dentrif=T by default. Change dynlakes test
to methane/use_nitrif_=T.
samsrabin added a commit to samsrabin/CTSM that referenced this pull request Oct 11, 2021
Change ceta from 450 to 358 for CTSM5.1 See Leo VanKamenhout's work on this in
ESCOMP#250. Note, this is used in the PPE work.
See van Kampenhout et al. (2017).  Turn Medlyn on for PHS off for clm51 and clm50.
Make max CO2 partial pressure consistent in Photosynthesis.
Change surface datasets to only use 78PFT versions
Fix GSSUN and GSSHA history variables so now not just writing missing values.
Changes FATES to run with use_nitrif_dentrif=T by default. Change dynlakes test
to methane/use_nitrif_=T.
samsrabin pushed a commit to samsrabin/CTSM that referenced this pull request May 3, 2024
add namelist lookup to each namelist read call
@samsrabin samsrabin added the science Enhancement to or bug impacting science label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete science Enhancement to or bug impacting science
Development

Successfully merging this pull request may close these issues.

7 participants