Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactoring of neon_site into tower_site, and neon_site #2344

Closed
wants to merge 5 commits into from

Conversation

TeaganKing
Copy link
Contributor

Description of changes

This PR will create a BaseSite class which defines common structures that are in both NeonSite and Plumber2Site classes. The TowerSite class (child of BaseSite) will define common
functionalities that are in both NeonSite and Plumber2Site classes. With this structure, we will be able to implement a Plumber2Site class parallel to the NeonSite class that utilizes structure and functionalities in the parent classes.

Contributors other than yourself, if any:
@ekluzek
@adrifoster

CTSM Issues Fixed (include github issue #):
This will address part of #1487

Are answers expected to change (and if so in what way)?
No, this PR should be BFB.

Any User Interface Changes (namelist or namelist defaults changes)?
No

@TeaganKing TeaganKing self-assigned this Feb 1, 2024
@TeaganKing TeaganKing added PR status: work in progress bfb bit-for-bit enhancement new capability or improved behavior of existing capability labels Feb 1, 2024
@TeaganKing
Copy link
Contributor Author

In a discussion with @ekluzek we decided to keep BaseSite and TowerSite classes combined in order to avoid scope creep.

TowerSite will include build_base_case, get_batch_query, and set_ref_case. A basic modify_user_nl function will be included in TowerSite, with extensions for NEON (and eventually PLUMBER) located in NeonSite (and eventually Plumber2Site). Some functionality from run_case will be brought out into TowerSite as well, while details specific to NEON will be in NeonSite.

@TeaganKing TeaganKing changed the title [WIP] Refactoring of neon_site into base_site, tower_site, and neon_site [WIP] Refactoring of neon_site into tower_site, and neon_site Feb 6, 2024
@TeaganKing
Copy link
Contributor Author

Closing and using #2363 instead...

@TeaganKing TeaganKing closed this Feb 13, 2024
@TeaganKing TeaganKing deleted the base_class branch June 24, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant