initializing gru products to zero in fates runs #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgknox
changed the title
|
Testing on cheyenne is as expected, all tests b4b with dev142, with exception of FATES tests that track wood products (ERP_Ld9.f45_f45_mg37.I2000Clm50FatesRs.cheyenne_intel.clm-FatesColdAllVars.GC.1010-133407ch_int). Those values now (intentionally) have 0's instead of unitialized: /glade/scratch/rgknox/tests_1010-133407ch Testing on Izumi is all pass: /scratch/cluster/rgknox/tests_1011-125117iz |
ekluzek
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The cn_products gru pools were not being initialized for a fates run. They are set to zero. In the future when fates can accomodate lu transitions and products, we will update this field accordingly.
Specific notes
Contributors other than yourself, if any:
software dev team, @ekluzek
CTSM Issues Fixed (include github issue #):
Fixes #2165
Are answers expected to change (and if so in what way)?
wood product variables will now include a zero instead of an uninitialized for calculations, at least on the first time-step for a fates-clm run. Since the history omits averaging of with uninitialized, and the gru variables only contribute partially to the total wood product diagnostic in fates-clm tests, I don't think this will have an effect on the output.
Any User Interface Changes (namelist or namelist defaults changes)? no
Testing performed, if any: Ran standard testing