Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building energy fix (issue #803). #1034

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Conversation

olyson
Copy link
Contributor

@olyson olyson commented Jun 8, 2020

Description of changes

There is an implicit assumption in the urban building energy model that building width equals street width. However, this assumption has been relaxed and building width is now derived from the morphology dataset.

Specific notes

There is an implicit assumption in the urban building energy model that building width equals street width. However, this assumption has been relaxed and building width is now derived from the Jackson morphology dataset. Specifically, the equations which use H/Ws (building height over street width) now use H/Wb (building height over building width). Building width is derived from (Ws*froof)/(1-froof), where froof is the roof (building) fraction.
A simulation with the new equations indicate that as expected, for froof=0.5, answers are identical (because H/Ws = H/Wb). Differences in other cases depend on the degree of departure from froof=0.5 and the presence and magnitude of space heating and air conditioning.

Contributors other than yourself, if any: None

CTSM Issues Fixed (include github issue #): #803

Are answers expected to change (and if so in what way)? Yes, but only for urban landunits. The effects on grid cell averages are very small as shown by the diagnostics from this year 2000 case:

http://webext.cgd.ucar.edu/I2000/clm50_ctsm10d098_1deg_GSWP3V1_CON_FIXBUILDENERGY_2000/lnd/clm50_ctsm10d098_1deg_GSWP3V1_CON_FIXBUILDENERGY_2000.1991_2010-clm50_ctsm10d098_1deg_GSWP3V1_CON_2000.1991_2010/setsIndex.html

Any User Interface Changes (namelist or namelist defaults changes)? No.

Testing performed, if any:
The clm_short testlist was run. All pass except comparison to ctsm1.0.dev098 baseline was not bfb as expected.

Performance verified through spreadsheet CTSM98_BUILDENERGY_Analysis_Pub
Change some hardcoded parameters to go on the parameter files. This is needed in preparation
of running the Perturbed Parameter Ensemble.
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability and removed enhancement new capability or improved behavior of existing capability labels Jun 25, 2020
@ekluzek ekluzek modified the milestone: cesm2.2.0 Jun 25, 2020
@ekluzek
Copy link
Collaborator

ekluzek commented Jun 25, 2020

I appended this onto the luna-bug fix branch tag and ran the testing. All tests have passed as expected, and the clm4_5 answers don't change as expected.

@ekluzek ekluzek merged commit bec2729 into ESCOMP:master Jun 25, 2020
@samsrabin samsrabin added bug something is working incorrectly science Enhancement to or bug impacting science labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is working incorrectly science Enhancement to or bug impacting science
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants