Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I1850Clm51BgcCrop actually uses CLM50 #1882

Closed
billsacks opened this issue Oct 25, 2022 · 2 comments
Closed

I1850Clm51BgcCrop actually uses CLM50 #1882

billsacks opened this issue Oct 25, 2022 · 2 comments
Labels
bug something is working incorrectly

Comments

@billsacks
Copy link
Member

billsacks commented Oct 25, 2022 •
edited
Loading

Brief summary of bug

In reviewing config_compsets.xml, I noticed that the compsets I1850Clm51Bgc and I1850Clm51BgcCrop actually use CLM50.

General bug information

CTSM version you are using: master

Does this bug cause significantly incorrect results in the model's science? Yes

Configurations affected: compsets I1850Clm51Bgc and I1850Clm51BgcCrop
@billsacks billsacks added bug something is working incorrectly next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Oct 25, 2022
@billsacks billsacks changed the title I1850Clm51Bgc and I1850Clm51BgcCrop actually use CLM50 I1850Clm51BgcCrop actually uses CLM50 Oct 25, 2022
@billsacks
Copy link
Member Author

Actually, I1850Clm51Bgc is okay because it is defined twice in config_compsets.xml: once correctly and once incorrectly, and the correct one is picked up. So in that case, we should simply remove the second, incorrect definition of that compset.

I propose making a small tag with this change. Let's discuss when this should come in relative to other tags at our Thursday meeting. Even though I rarely do this, in this case I feel like it would be sufficient to just run the small number of tests with these two compsets (making sym links to other tests); @ekluzek or others, let me know if you object to that plan.

@billsacks
Copy link
Member Author

I'll go ahead with the above plan, based on today's discussion.

@billsacks billsacks removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Oct 27, 2022
billsacks added a commit that referenced this issue Oct 28, 2022
@billsacks
Merge branch 'compset_fixes'
fbfa05f 
Fix some compsets; add only clauses for ESMF use statements

(1) Fix I1850Clm51BgcCrop compset (was using CLM50 instead of CLM51)
- Resolves #1882

(2) Change LND_TUNING_MODE for DATM%CPLHIST compsets to use CAM tunings
    since these cases typically use atmosphere forcings from CAM.
- Resolves #1885

(3) Add "only" clauses to ESMF use statements
- Resolves #1846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something is working incorrectly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@billsacks