Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-standard namelist parameter: cmb_cmplt_fact #1053

Closed
djk2120 opened this issue Jun 22, 2020 · 3 comments · Fixed by #1102
Closed

Non-standard namelist parameter: cmb_cmplt_fact #1053

djk2120 opened this issue Jun 22, 2020 · 3 comments · Fixed by #1102
Assignees
Labels
enhancement new capability or improved behavior of existing capability

Comments

@djk2120
Copy link
Contributor

djk2120 commented Jun 22, 2020

cmb_cmplt_fact is a parameter under namelist control pertaining to the fire model (combustion completion factor [unitless])

As far as I can tell it is the only real-valued, namelist-controlled parameter that is not a single value. Instead it has two elements, which are by default: 0.5 and 0.25. The first values corresponds to litter and the second to coarse woody debris.

If possible we might split this into two parameters to avoid having a special case when it comes to editing namelist parameters.

@ekluzek ekluzek self-assigned this Jun 22, 2020
@ekluzek ekluzek added the enhancement new capability or improved behavior of existing capability label Jun 22, 2020
@ekluzek
Copy link
Collaborator

ekluzek commented Jun 22, 2020

It wouldn't be too hard to split it into two with adding for example a "_cwd" and "_litter" suffix to it. I wonder if we should bring it directly to the params file though? If so would you want it separated out there as well?

There are a few other array valued real namelist items, but I think you likely wouldn't be messing with them: soil_layerstruct_userdefined, initial_Cstocks, initial_Cstocks_depth, albice, lake_melt_icealb. Do you agree that you wouldn't be changing any of those?

@djk2120
Copy link
Contributor Author

djk2120 commented Jun 22, 2020

Either way I think it would be ideal to separate them. Agreed on the suffix idea. I would say perhaps namelist for now, because several other fire parameters are controlled directly from the namelist. But I would certainly defer to you on that...

@djk2120
Copy link
Contributor Author

djk2120 commented Jun 22, 2020

And yes, agreed, we have no plans to alter any of those other namelist items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability
Development

Successfully merging a pull request may close this issue.

2 participants