Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSP tests fail if you try to rerun them #1021

Closed
billsacks opened this issue May 24, 2020 · 1 comment
Closed

SSP tests fail if you try to rerun them #1021

billsacks opened this issue May 24, 2020 · 1 comment
Assignees
@billsacks
Labels
testing additions or changes to tests

Comments

@billsacks
Copy link
Member

If you try to rerun an SSP test, you get an error like this:

2020-05-23 17:15:34: Exception during run:
[Errno 17] File exists
Traceback (most recent call last):
  File "/glade/work/sacks/ctsm_code/current_branch1/cime/scripts/Tools/../../scripts/lib/CIME/SystemTests/system_tests_common.py", line 151, in run
    self.run_phase()
  File "/glade/work/sacks/ctsm_code/current_branch1/cime_config/SystemTests/ssp.py", line 86, in run_phase
    os.symlink(item, os.path.join(rundir, os.path.basename(item)))
OSError: [Errno 17] File exists

It looks like this should be as easy as wrapping the os.symlink call in a conditional. I'll take a stab at it.
@billsacks billsacks added the testing additions or changes to tests label May 24, 2020
@billsacks billsacks self-assigned this May 24, 2020
@billsacks
Copy link
Member Author

I have tested with 4665c9c, and that indeed resolves this issue. I'll bring that to master very soon.

billsacks added a commit that referenced this issue May 25, 2020
@billsacks
Merge branch 'bioenergy_ctsm1.0.dev080'
6ec6e0a 
Add two bioenergy crops (switchgrass and miscanthus)

Main change is from Yanyan Cheng: adding parameters and code for two
bioenergy crops, switchgrass and miscanthus. Along with this, there is a
new potential flux from crop leaves and stems to the crop product pool
at harvest, representing biofuel products; a new pft-specific parameter
controls this flux (biofuel_harvfrac). Currently, the out-of-the-box
surface datasets do not specify any area for these crops, but the new
parameter file will allow them to be present if specified on the surface
dataset or landuse_timeseries file. Note that this is only an option for
CLM5.0, NOT for CLM4.5. (See #884 for
details.)

Also, some minor fixes from Bill Sacks:
- Resolves #203 - Fixes creation of harvest-related variables
  on surface datasets created with the all_veg option - smallville,
  PTCLM, etc. (documented in #1019)
- Resolves #930 - Makes gindex_ocn intent(inout) rather than
  intent(out)
- Resolves #1021 - Changes SSP test to only do symlink if
  needed
ekluzek added a commit to jtruesdal/ctsm that referenced this issue May 27, 2020
@ekluzek
Merge tag 'ctsm1.0.dev097' into fv3port
6c521ba 
Add two bioenergy crops (switchgrass and miscanthus)

Main change is from Yanyan Cheng: adding parameters and code for two
bioenergy crops, switchgrass and miscanthus. Along with this, there is a
new potential flux from crop leaves and stems to the crop product pool
at harvest, representing biofuel products; a new pft-specific parameter
controls this flux (biofuel_harvfrac). Currently, the out-of-the-box
surface datasets do not specify any area for these crops, but the new
parameter file will allow them to be present if specified on the surface
dataset or landuse_timeseries file. Note that this is only an option for
CLM5.0, NOT for CLM4.5. (See ESCOMP#884 for
details.)

Also, some minor fixes from Bill Sacks:
- Resolves ESCOMP#203 - Fixes creation of harvest-related variables
  on surface datasets created with the all_veg option - smallville,
  PTCLM, etc. (documented in ESCOMP#1019)
- Resolves ESCOMP#930 - Makes gindex_ocn intent(inout) rather than
  intent(out)
- Resolves ESCOMP#1021 - Changes SSP test to only do symlink if
  needed
ekluzek added a commit to ekluzek/CTSM that referenced this issue Jun 10, 2020
@ekluzek
Merge tag 'ctsm1.0.dev097' into simb4b
be3e551 
Add two bioenergy crops (switchgrass and miscanthus)

Main change is from Yanyan Cheng: adding parameters and code for two
bioenergy crops, switchgrass and miscanthus. Along with this, there is a
new potential flux from crop leaves and stems to the crop product pool
at harvest, representing biofuel products; a new pft-specific parameter
controls this flux (biofuel_harvfrac). Currently, the out-of-the-box
surface datasets do not specify any area for these crops, but the new
parameter file will allow them to be present if specified on the surface
dataset or landuse_timeseries file. Note that this is only an option for
CLM5.0, NOT for CLM4.5. (See ESCOMP#884 for
details.)

Also, some minor fixes from Bill Sacks:
- Resolves ESCOMP#203 - Fixes creation of harvest-related variables
  on surface datasets created with the all_veg option - smallville,
  PTCLM, etc. (documented in ESCOMP#1019)
- Resolves ESCOMP#930 - Makes gindex_ocn intent(inout) rather than
  intent(out)
- Resolves ESCOMP#1021 - Changes SSP test to only do symlink if
  needed
ekluzek added a commit to juliusvira/ctsm that referenced this issue Aug 22, 2022
@ekluzek
Merge tag 'ctsm1.0.dev097' into fan-2019-ctsm
1646e04 
Add two bioenergy crops (switchgrass and miscanthus)

Main change is from Yanyan Cheng: adding parameters and code for two
bioenergy crops, switchgrass and miscanthus. Along with this, there is a
new potential flux from crop leaves and stems to the crop product pool
at harvest, representing biofuel products; a new pft-specific parameter
controls this flux (biofuel_harvfrac). Currently, the out-of-the-box
surface datasets do not specify any area for these crops, but the new
parameter file will allow them to be present if specified on the surface
dataset or landuse_timeseries file. Note that this is only an option for
CLM5.0, NOT for CLM4.5. (See ESCOMP#884 for
details.)

Also, some minor fixes from Bill Sacks:
- Resolves ESCOMP#203 - Fixes creation of harvest-related variables
  on surface datasets created with the all_veg option - smallville,
  PTCLM, etc. (documented in ESCOMP#1019)
- Resolves ESCOMP#930 - Makes gindex_ocn intent(inout) rather than
  intent(out)
- Resolves ESCOMP#1021 - Changes SSP test to only do symlink if
  needed

 Conflicts:
	Externals.cfg
	bld/namelist_files/namelist_defaults_ctsm.xml
	bld/namelist_files/namelist_definition_ctsm.xml
	bld/unit_testers/build-namelist_test.pl
	src/biogeochem/CNBalanceCheckMod.F90
	src/biogeochem/CNDriverMod.F90
	src/biogeochem/CNVegetationFacade.F90
	src/main/clm_driver.F90
	src/main/clm_initializeMod.F90
	src/main/controlMod.F90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billsacks billsacks

Labels
testing additions or changes to tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@billsacks