Skip to content

Commit

Permalink
Merge branch 'lilac_project'
Browse files Browse the repository at this point in the history
Add --project argument to LILAC's create_newcase command

This isn't needed by anything in the LILAC workflow, but cime requires
it on machines that expect PROJECT to be set. I guess that, until now,
everyone who was testing and using the LILAC workflow had PROJECT set in
their environment, or a .cesm_proj file in their home
directory. @glemieux ran into this issue, however, and it would likely
affect others.

Testing performed:
- python testing (on my mac)
- LILACSMOKE_Vnuopc_D_Ld2.f10_f10_musgs.I2000Ctsm50NwpSpAsRsGs.cheyenne_intel.clm-lilac

In my view, that is sufficient testing, since those are the only tests that would touch this code.

I ran the system test when I had temporarily unset PROJECT from the environment and removed my .cesm_proj file.

See also #1146
  • Loading branch information
billsacks committed Sep 10, 2020
2 parents 8550666 + df66cc2 commit 9790450
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions python/ctsm/lilac_build_ctsm.py
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,9 @@ def _create_case(cime_path, build_dir, compiler,
'--res', _RES,
'--compiler', compiler,
'--driver', 'nuopc',
# Project isn't used for anything in the LILAC workflow, but it
# still needs to be specified on machines that expect it.
'--project', 'UNSET',
'--run-unsupported']
create_newcase_cmd.extend(machine_args)
if inputdata_path:
Expand Down

0 comments on commit 9790450

Please sign in to comment.